chore: remove moto from setup. leave in requirements_dev #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenkilbourn
changed the title
anayeaye
approved these changes
Aug 16, 2024
botanical
added a commit
that referenced
this pull request
Aug 20, 2024
…ltiple domain names for prod, Improve raster integration tests, remove moto from setup. leave in requirements_dev (#423) ### 🪙 Changed/Updated - [chore: Improve raster integration tests #397](#397) - [chore: remove moto from setup. leave in requirements_dev #421](#421) ### 🩹 Fixed - [fix: update domain names to support multiple domain names for prod](#418 ) <details> <summary>Authors</summary> - Co-authored-by: Jennifer Tran - Co-authored-by: Stephen Kilbourn </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
We were seeing
cannot import name 'mock_dynamodb' from 'motobecause moto made a breaking change on the imports in moto version 5.We already have
moto[dynamodb, ssm]>=4.0.9,<5.0in the ingest apirequirements_devto address this, but there was an unpinned version in thesetup.py. I'm making this change to just have the import with the pinned version in a single location.