fix: include stage subdomain in cloudfront distribution #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smohiudd
changed the title
anayeaye
approved these changes
Oct 13, 2023
| ), | ||
| cache_policy=cf.CachePolicy.CACHING_DISABLED, | ||
| ), | ||
| certificate=domain_cert, | ||
| domain_names=[veda_route_settings.domain_hosted_zone_name] | ||
| domain_names=[f"{stage}.{veda_route_settings.domain_hosted_zone_name}"] | ||
| if veda_route_settings.domain_hosted_zone_name | ||
| else None, | ||
| additional_behaviors={ | ||
| "/api/stac*": cf.BehaviorOptions( |
There was a problem hiding this comment.
I missed this additional behaviors in the last PR, maybe we can drop a TODO here to make this configurable in the condition that a path prefex is used like f"{veda_route_settings.stac_path_prefix}*": cf.BehaviorOptions(.... I think we can work on that after using things for a while though, to see what our needs are
| @@ -89,7 +90,7 @@ def __init__( | |||
| ] = aws_apigatewayv2_alpha.ParameterMapping().overwrite_header( | |||
| "host", | |||
| aws_apigatewayv2_alpha.MappingValue( | |||
| veda_raster_settings.domain_hosted_zone_name | |||
| f"{stage}.{veda_raster_settings.domain_hosted_zone_name}" | |||
There was a problem hiding this comment.
comment for future work: maybe we can add a method in the api config files to add a stage subdomain for all non-prod stages? We don't need that now so it's just something to think about.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cloudfront distribution includes the
stageenv as the subdomain:{stage}.{domain_hosted_zone_name}.com