Add new check for OPeNDAP for granules #305
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binni979
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request introduces a new check to verify the presence of OPeNDAP links in granule URL fields. The goal is to ensure that OPeNDAP links are included in the URL fields of granule metadata.
New Check Details
Check: Verify if OPeNDAP links are present in specified URL fields.
Fields:
Granule/OnlineResources/OnlineResource/URL (echo-g)
RelatedURLs/URL (umm-g)
Check Logic
The check inspects the specified URL fields for the presence of "opendap" in the URL.
If "opendap" is not found, a warning is generated, recommending the addition of an OPeNDAP link for this granule.
Implementation Steps
Added a new function, opendap_link_check, to perform the URL validation.
Added rule_mapping.json to include this new check.
Added checks.json to enable the OPeNDAP link check.
Added check_message.json to define warning messages for missing OPeNDAP links.
Testing
Tested Granules:
Granules that have opendap in URL, No opendap error was reported.
umm-g: G1997478801-LARC_ASDC (Does not contain "opendap" in URL or have URL type "OPENDAP DATA") – Error: Warning generated to recommend adding an OPeNDAP link.