Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-redirect library update through resolution section of package.json #411

Merged
merged 1 commit into from
Oct 27, 2024

Conversation

ShreyNiraula
Copy link
Collaborator

I have added the follow-redirects version 1.15.6 in the resolution section of the package.json. This will ensure that this version of follow-redirect will be used and current vulnerability will be resolved.

…s will ensure that the this version of follow-redirects library will be used
@krisstanton
Copy link
Collaborator

Linked Ticket: #396

@krisstanton
Copy link
Collaborator

Sandbox Deployment Passed.
Smoke Test on Sandbox Passed.

Approving now and following up with UAT smoke test now.

Copy link
Collaborator

@krisstanton krisstanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

@krisstanton
Copy link
Collaborator

I am not sure why deployment to UAT did not happen, will go forward with the merge deployment since Sandbox items worked as expected.

@krisstanton krisstanton merged commit 66c457a into main Oct 27, 2024
4 checks passed
@chuckwondo
Copy link
Collaborator

I am not sure why deployment to UAT did not happen, will go forward with the merge deployment since Sandbox items worked as expected.

It's because the only file that changed was package.json. However, when updating dependencies in that file, you need to run make install in order for yarn.lock to be updated.

NOTE: you may want to remove zip_lambdas as a dependency on your install recipe in Makefile. I attempted to run make install (after pulling the latest code from main) and noticed that it was taking forever to run, so I killed it. I then removed zip_lambdas as a dependency of install (i.e., instead of the line install: docker zip_lambdas it's just install: docker), and reran make install.

This caused yarn.lock to be updated as shown by running git diff afterwards:

-follow-redirects@^1.15.4, follow-redirects@^1.2.4:
-  version "1.15.5"
-  resolved "https://registry.yarnpkg.com/follow-redirects/-/follow-redirects-1.15.5.tgz#54d4d6d062c0fa7d9d17feb008461550e3ba8020"
-  integrity sha512-vSFWUON1B+yAw1VN4xMfxgn5fTUiaOzAJCKBwIIgT/+7CuGy9+r+5gITvP62j3RmaD5Ph65UaERdOSRGUzZtgw==
+follow-redirects@^1.15.4, follow-redirects@^1.15.6, follow-redirects@^1.2.4:
+  version "1.15.9"
+  resolved "https://registry.yarnpkg.com/follow-redirects/-/follow-redirects-1.15.9.tgz#a604fa10e443bf98ca94228d9eebcc2e8a2c8ee1"
+  integrity sha512-gew4GsXizNgdoRyqmyfMHyAmXsZDk6mHkSxZFCzW9gwlbtOW44CDtYavM+y+72qD/Vq2l550kMF52DT8fOLJqQ==

When yarn.lock is updated (and committed/pushed), then UAT will be deployed. Whether or not deployment to UAT, and subsequently Prod, occurs is determined by whether or not a file matching any of the patterns listed in the paths lists within .github/workflows/main.yml is changed. Notice that package.json is not in either paths list, but yarn.lock is.

@krisstanton
Copy link
Collaborator

Thanks for the info @chuckwondo.
I'll make these changes and make another PR off the just merged branch just to ensure this all works!

@krisstanton
Copy link
Collaborator

Linked Second Pull Request (Where the actual update to Makefile and yarn.lock happened as per comments above)
#412

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants