Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update exclude checkmark action to change behavior based on inclusion status #1167

Conversation

Kirandawadi
Copy link
Collaborator

Changes made:

Enhanced get_queryset() in DeltaURLViewSet inside views.py with new annotations:

  • Added exclude_pattern_type: Indicates type of exclude pattern affecting the URL
  • Added include_pattern_id: Stores ID of any include pattern affecting the URL

Modified handleExcludeIndividualUrlClick() in delta_url_list.js:

  • Now checks if URL is affected by multi-URL exclude pattern using new exclude_pattern_type annotation
  • For multi-URL patterns: Creates/deletes individual include pattern to override exclusion
  • For individual URL patterns: Toggles individual exclude pattern directly
  • Uses include_pattern_id annotation to delete override patterns when needed

Copy link
Contributor

@bishwaspraveen bishwaspraveen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bishwaspraveen bishwaspraveen merged commit 99a72f4 into dev Jan 8, 2025
5 checks passed
@bishwaspraveen bishwaspraveen deleted the 1156-update-exclude-checkmark-action-to-change-behavior-based-on-inclusion-status branch January 8, 2025 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Exclude Checkmark Action to Change Behavior Based on Inclusion Status
2 participants