Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CameraTransition: Add support for rotation transition #931

Merged
merged 8 commits into from
Jan 18, 2025

Conversation

gkjohnson
Copy link
Contributor

@gkjohnson gkjohnson commented Jan 18, 2025

Fix #831

TODO

  • Remove the need for a separate "targetPos" variable
  • Make it simpler to extract the ortho position with height
  • Add option for example to transition to predetermined viewpoint
    • shift perspective camera down slightly
    • consider just rotating the ortho camera orientation so it's facing the same direction
  • Test and fix mid-transition toggle logic (right now it jumps)
  • Add option for the transition camera transform can be applied when interrupting the transition

@gkjohnson gkjohnson marked this pull request as ready for review January 18, 2025 13:39
@gkjohnson gkjohnson merged commit ecac103 into master Jan 18, 2025
2 checks passed
@gkjohnson gkjohnson deleted the rotation-transition branch January 18, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CameraTransitionManager: Reorient the transition camera around the fixed point
1 participant