rosetta failed pt fix #20411
Merged
rosetta failed pt fix #20411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickkuo
requested review from
asonnino,
akichidis,
amnn,
wlmyng,
stefan-mysten,
emmazzz and
suiwombat
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
github-actions
bot
added
the
Type: Documentation
patrickkuo
changed the base branch from
main
to
releases/sui-v1.37.0-release
patrickkuo
removed request for
amnn,
emmazzz,
akichidis,
asonnino,
suiwombat,
wlmyng and
stefan-mysten
patrickkuo
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
github-actions
bot
removed
the
Type: Documentation
patrickkuo
force-pushed
the
pat/rosetta-failed-pt-fix
branch
from
1fefe29
to
f92c416
Compare
patrickkuo
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
patrickkuo
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
nikos-terzo
approved these changes
Nov 24, 2024
patrickkuo
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
nikos-kitmeridis
approved these changes
Nov 25, 2024
|
Thanks for that @patrickkuo. |
Yes, need to cherrypick into main and 1.38 once it’s merged |
patrickkuo
merged commit f2f5e77
into
releases/sui-v1.37.0-release
50 of 52 checks passed
patrickkuo
added a commit
that referenced
this pull request
Nov 25, 2024
## Description do not attempt to parse programmable transaction for failed transactions to avoid parsing error ## Test plan How did you test the new or updated feature? --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] REST API:
patrickkuo
added a commit
that referenced
this pull request
Nov 25, 2024
## Description do not attempt to parse programmable transaction for failed transactions to avoid parsing error ## Test plan How did you test the new or updated feature? --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] REST API:
patrickkuo
added a commit
that referenced
this pull request
Nov 25, 2024
## Description do not attempt to parse programmable transaction for failed transactions to avoid parsing error ## Test plan How did you test the new or updated feature? --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] REST API: ## Description Describe the changes or additions included in this PR. ## Test plan How did you test the new or updated feature? --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] REST API:
patrickkuo
added a commit
that referenced
this pull request
Nov 25, 2024
## Description do not attempt to parse programmable transaction for failed transactions to avoid parsing error ## Test plan How did you test the new or updated feature? --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] REST API: ## Description Describe the changes or additions included in this PR. ## Test plan How did you test the new or updated feature? --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] REST API:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
do not attempt to parse programmable transaction for failed transactions to avoid parsing error
Test plan
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.