Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[formatter] Adds prettier-extension #20363

Merged
merged 7 commits into from
Nov 22, 2024
Merged

[formatter] Adds prettier-extension #20363

merged 7 commits into from
Nov 22, 2024

Conversation

damirka
Copy link
Contributor

@damirka damirka commented Nov 21, 2024

Description

Adds extension bundler.

Test plan

How did you test the new or updated feature?


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:
  • REST API:

Copy link

vercel bot commented Nov 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 2:54pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 2:54pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 2:54pm
sui-typescript-docs ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 2:54pm

@damirka damirka temporarily deployed to sui-typescript-aws-kms-test-env November 21, 2024 08:49 — with GitHub Actions Inactive
Copy link
Contributor

github-actions bot commented Nov 21, 2024

⚠️ 🦋 Changesets Warning: This PR has changes to public npm packages, but does not contain a changeset. You can create a changeset easily by running pnpm changeset in the root of the Sui repo, and following the prompts. If your change does not need a changeset (e.g. a documentation-only change), you can ignore this message. This warning will be removed when a changeset is added to this pull request.

Learn more about Changesets.

Copy link

@tedks tedks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Have reviewed the typescript to the best of my ability.

@damirka damirka temporarily deployed to sui-typescript-aws-kms-test-env November 22, 2024 12:50 — with GitHub Actions Inactive
@damirka damirka temporarily deployed to sui-typescript-aws-kms-test-env November 22, 2024 14:53 — with GitHub Actions Inactive
@damirka damirka merged commit abdd331 into main Nov 22, 2024
52 checks passed
@damirka damirka deleted the ds/prettier-extension branch November 22, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants