Skip to content

Commit

Permalink
[zksend SDK] fix getSentTransactions not respecting the passed in Sui…
Browse files Browse the repository at this point in the history
…Client URL (#20334)

## Description 

Context:
https://mysten-labs.slack.com/archives/C0701K5UHCP/p1732048923401389

We aren't passing through the Sui client instance to `loadAssets`, so
it's defaulting to the public fullnode URL in Stashed which has heavier
rate limits as opposed to our internal RPC.

<img width="1696" alt="image"
src="https://github.com/user-attachments/assets/7d70fd2f-4532-406f-a591-1790f83ee108">


## Test plan 

How did you test the new or updated feature?

---

## Release notes

Check each box that your changes affect. If none of the boxes relate to
your changes, release notes aren't required.

For each box you select, include information after the relevant heading
that describes the impact of your changes that a user might notice and
any actions they must take to implement updates.

- [ ] Protocol: 
- [ ] Nodes (Validators and Full nodes): 
- [ ] Indexer: 
- [ ] JSON-RPC: 
- [ ] GraphQL: 
- [ ] CLI: 
- [ ] Rust SDK:
- [ ] REST API:
  • Loading branch information
williamrobertson13 authored Nov 19, 2024
1 parent 762fc34 commit f03e60f
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
5 changes: 5 additions & 0 deletions .changeset/shiny-cups-sniff.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@mysten/zksend': patch
---

Fix getSentTransactionsWithLinks defaulting to the public fullnode URL
1 change: 1 addition & 0 deletions sdk/zksend/src/links/get-sent-transactions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ export async function getSentTransactionsWithLinks({
address,
contract,
isContractLink: true,
client,
...linkOptions,
});

Expand Down

0 comments on commit f03e60f

Please sign in to comment.