Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add info for local SCION setup #49

Merged
merged 1 commit into from
Nov 28, 2023
Merged

docs: add info for local SCION setup #49

merged 1 commit into from
Nov 28, 2023

Conversation

mlegner
Copy link
Contributor

@mlegner mlegner commented Nov 24, 2023 •
edited
Loading

Contributes to #27

@mlegner mlegner added the documentation Improvements or additions to documentation label Nov 24, 2023
@mlegner mlegner requested a review from jpcsmith November 24, 2023 14:20
@mlegner mlegner force-pushed the docs/local-scion-setup branch from e7add21 to 9f0becd Compare November 27, 2023 12:49
@mlegner mlegner marked this pull request as ready for review November 27, 2023 17:51
jpcsmith
jpcsmith approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@jpcsmith jpcsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Looks good, is this something that makes sense to automate with Vagrant at some point? If so, we could add a issue for it.

CONTRIBUTING.md Show resolved Hide resolved
@jpcsmith jpcsmith mentioned this pull request Nov 28, 2023
Closed
@jpcsmith jpcsmith merged commit ad54c6a into main Nov 28, 2023
11 checks passed
@jpcsmith jpcsmith deleted the docs/local-scion-setup branch November 28, 2023 11:39
@mlegner mlegner mentioned this pull request Nov 28, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpcsmith jpcsmith jpcsmith approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mlegner @jpcsmith