Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(MOS-1414): Handle non-existent Twig and Profiler services. #18

Merged
merged 8 commits into from
Mar 14, 2024
Merged

fix(MOS-1414): Handle non-existent Twig and Profiler services. #18

merged 8 commits into from
Mar 14, 2024

Conversation

TomPeters-NL
Copy link

😭 Issue

Monolith environments other than dev might not include the profiler or twig services, causing errors.

😍 Solution

  • Added on-invalid="null" to twig and profiler service arguments.
  • Handle null services in PanelController with simple error responses.

🚀 Release

This will be version 1.7.15.

@TomPeters-NL TomPeters-NL added the bug Something isn't working label Mar 14, 2024
@TomPeters-NL TomPeters-NL requested a review from a team March 14, 2024 13:32
@TomPeters-NL TomPeters-NL merged commit 34a679c into 1.7 Mar 14, 2024
1 check passed
@TomPeters-NL TomPeters-NL deleted the MOS-1414-compiler-pass-build branch March 14, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartvanraaij bartvanraaij bartvanraaij approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomPeters-NL @bartvanraaij