Remove pyinstaller temporary directory from macOS dist directory befo…

…re creating macOS dmg. Don't codesign the macOS dmg file itself.
MusculoskeletalAtlasProject · Jan 30, 2024 · d3831cd · d3831cd
1 parent 8a7c56a
commit d3831cd
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/.github/workflows/on-demand-deployment.yaml b/.github/workflows/on-demand-deployment.yaml
@@ -263,7 +263,7 @@ jobs:
       - name: Notarize and Staple installer (macOS)
         if: runner.os == 'macOS'
         run: |
-          codesign -s "${{ secrets.APPLE_DEV_ID_APPLICATION}}" --timestamp --force "${{ steps.create-installer.outputs.file }}"
+          #codesign -s "${{ secrets.APPLE_DEV_ID_APPLICATION}}" --timestamp --force "${{ steps.create-installer.outputs.file }}"
           xcrun notarytool submit "${{ steps.create-installer.outputs.file }}" --apple-id ${{ secrets.APPLE_NOTARIZATION_USERNAME }} --password ${{ secrets.APPLE_NOTARIZATION_PASSWORD }} --team-id ${{ secrets.APPLE_DEV_TEAM_ID }} --wait
           xcrun stapler staple "${{ steps.create-installer.outputs.file }}"
 

diff --git a/res/macos/create_installer.sh b/res/macos/create_installer.sh
@@ -2,9 +2,12 @@
 version=$1
 variant=$2
 
+src_dir="../pyinstaller/dist/"
+
 app_name=MAP-Client$variant
 app_name_with_version=MAP-Client$variant-$version
 dmg_name=$app_name_with_version.dmg
+test -d $src_dir/$app_name && rm -rf $src_dir/$app_name
 test -f $dmg_name && rm $dmg_name
 #  --volicon "application_icon.icns" \
 create-dmg \
@@ -18,5 +21,5 @@ create-dmg \
   --hide-extension "$app_name.app" \
   --app-drop-link 600 185 \
   "$dmg_name" \
-  "../pyinstaller/dist/"
+  "$src_dir"