forked from ooni/probe-cli
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
refactor(MeasuringNetwork): define dialers without resolver (ooni#1259)
I initially planned on defining only the dialers with resolver and explicitly passing `&NullResolver{}` to them. But I have just realized that, instead, defining the dialers without resolvers (which is what measurexlite needs anyway) will allow me to rewrite the without-resolver case to be very simple and completely ignore resolvers. Once I have done this rewrite, we can keep the existing implementation for legacy code, but we can also have: 1. the above-mentioned simple dialing implementation without resolvers that fullfills measurexlite needs; 2. another implementation tailored to the needs of beacons. So, voila, I think I now have a reasonable way forward to introduce beacons support in netxlite. Part of ooni/probe#2531
1 parent
3a90f76
commit 31f2edc
Showing
5 changed files
with
62 additions
and
40 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters