-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for s132 (Don't include GeometryService in rootcling) #1329
Conversation
Update CMakeLists.txt for new files.
Hi @eflumerf,
which require these tests: build. @Mu2e/fnalbuild-users, @Mu2e/write have access to CI actions on main. ⌛ The following tests have been triggered for ebf8786: build (Build queue is empty) |
☀️ The build tests passed at ebf8786.
N.B. These results were obtained from a build of this Pull Request at ebf8786 after being merged into the base branch at 25d66e0. For more information, please check the job page here. |
@eflumerf is the need to exclude the section of Surface steps drive by the new root in art 3.15 or is it driven by something intrinsic to cmake? My own opinion is that data products should not use services but we have never been able to get agreement on that. |
Basically, in s132, fhicl-cpp 4.19.00 includes c++20 code. ROOT cling does not understand c++20, so you cannot have a The change I made hides the GeometryService methods from |
I think the result of this change to fhiclcpp is that you cannot include services in data products until ROOT is updated to support c++20 in |
Thanks Eric. I will approve and merge the PR and create an issue to discuss getting services out of data products, which I think is the preferred solution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the discussion in the Conversation tab about the use of services in data products. Eric's solution is good enough for now. I create issue #1330 to follow up.
I will merge now.
Update CMakeLists.txt for new files.
Make it so check_cmake.sh can be run as
./bin/check_cmake.sh
(no copy to base directory)