Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SimpleLogin to the available login/signup modules #611

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added SimpleLogin to the available login/signup modules #611

wants to merge 1 commit into from

Conversation

nguyenkims
Copy link

SimpleLogin is a social login provider that focus on protecting user identity. More info can be found on https://simplelogin.io

The PR is largely inspired from spotify and amazon one 😊.

@nguyenkims
Copy link
Author

Hi has anyone had time to look at this PR please?

@nguyenkims
Copy link
Author

Re

@MrSwitch
Copy link
Owner

Hi, can you remove it from the hello.all.js build, otherwise all good

@nguyenkims
Copy link
Author

@MrSwitch You mean removing simplelogin from Gruntfile.js right? In this case does user need to include simplelogin.js explicitly in order to use it?

@nguyenkims
Copy link
Author

@MrSwitch is there anything that I need to address in this PR?

@nguyenkims
Copy link
Author

@MrSwitch

@MrSwitch
Copy link
Owner

MrSwitch commented Nov 14, 2019

@MrSwitch You mean removing simplelogin from Gruntfile.js right? In this case does user need to include simplelogin.js explicitly in order to use it?

Yes please do, indeed they can pull it in separatly, there's a few examples in the demos/ folder

@nguyenkims
Copy link
Author

@MrSwitch I'm not sure how that would work for users, could you please point me to the right example? From what I see on the documentation, a new provider needs to be added into the hello.all.js right?

@nguyenkims
Copy link
Author

Any news on this?

@nguyenkims
Copy link
Author

re

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants