Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated LinkedIn Authorization URLs, no longer Legacy urls #487

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

WesMC
Copy link

@WesMC WesMC commented Mar 29, 2017

I noticed that the URLS for the linkedIn Oauth are considered legacy per here:
https://developer.linkedin.com/docs/oauth2-legacy

I simply replaced the links with their current modern counterpart per here:
https://developer.linkedin.com/docs/oauth2

@MrSwitch
Copy link
Owner

This is slightly more complicated to change. The grant_url is stored and verified by the proxy server which handles the exchange of the Authorization Code for the Access Token. Otherwise as HelloJS sits in the client it could quite easily ask the Proxy server to send the Client Secret to another address. Therefore obtaining it.

... so basically everyone is going to have to change this in 2 places. Perhaps i could verify the domain and protocol rather than the full path.

@MrSwitch
Copy link
Owner

See also MrSwitch/node-oauth-shim#23

@zerosimms
Copy link

Hey @MrSwitch, I know its like asking "how long is a piece of string?" But any rough idea when you'll get a chance to look at your proxy server to enable this?

@jyotigupta007
Copy link

Hey @MrSwitch, Would you you please let us know how much time it would take to solve this issue. So that linkedin social login will work.

@MrSwitch
Copy link
Owner

@jyotigupta007 sorry not had a chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants