Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hello scope #403

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Hello scope #403

wants to merge 9 commits into from

Conversation

MrSwitch
Copy link
Owner

  • Change modules: rename property scope to scope_map
  • Explicit blacklist of scopes. Standardized scopes are blacklisted and therefore ignored during a login request - unless explicitly defined in the module. This was implied previously by looking at all the mapped scopes in all the given module to see if the scope is a standardized one.
  • The request object which is passed to a [network].login function now uses the property query instead of qs to be consistant with the request object used by hello.api;
  • Adopt property popup in place of login defining the popup parameters. So now we the provider can define a default width. e.g.
popup: {
   width: 550
}
  • Allow for overriding request previously immutable properties. E.g.
hello(network).login({
   oauth: {auth: 'https://something.else/auth'}
});

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant