Add 'catch' to Promise api #377
Open
+10
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Only thing was 'catch' is a reserved word in ECMAScript 3, IE8 & 9 require this written in brackets e.g. Sorry about CI failing, testing server script needs attention. Let me get that working first. |
|
OK, fixed that one you mentioned and two others. |
|
Hi @MrSwitch anything else you would like me to update for this PR? |
|
Nope, looks ok. I haven't had a chance to sanity check it on older browsers. What have you tested it in thus far? |
|
Hi @MrSwitch, I've tested this in latest Chrome, FF and IE11. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding for consistency with native Promise objects for better use with code expecting a standard promise.