Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add module for Etsy API using OAuth 1.0a #280

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

al-the-x
Copy link

@al-the-x al-the-x commented Jul 3, 2015

  • Get started!
  • Research required fields:
    • api_key (for all requests)
    • client_id (for auth'd requests)
  • Research OAuth 1.0a with hello.js
  • Register a new Module with hello.js using:
    • OAuth 1.0a
    • default proxy
    • JSONP (to bypass CORS)
    • endpoints for auth, request, and token
    • endpoint mapping for standard requests: . . .
    • Scaffold tests? Where should they go?
    • Setup local OAuth proxy via Browser-Sync?
  • Add example implementation to demos/
  • Add tests for Etsy module? Where do per-module tests live?
  • Update documentation... Where is the per-module documentation?

Resources


This change is Reviewable

@al-the-x
Copy link
Author

al-the-x commented Jul 3, 2015

Having trouble tracking down functional tests for the modules. I found tests/specs/e2e/modules.js, but that appears to be trivial sanity checks. Advice, @MrSwitch?

@MrSwitch
Copy link
Owner

MrSwitch commented Jul 3, 2015

Mock up a resource reponse and name it tests/specs/stubs/[network]/[method]/[path].json, i.e. https://github.com/MrSwitch/hello.js/tree/master/tests/specs/stubs/twitter/get then add the expected transformation of the formatted data too
https://github.com/MrSwitch/hello.js/tree/master/tests/specs/unit/modules

If you have more tests in mind please include.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants