feat: allow to set initialSearchTerm
#33
Conversation
| const tenor = useContext(TenorContext); | ||
|
|
||
| useEffect(() => { | ||
| setLoading(true); | ||
| async function search(): Promise<any> { | ||
| const result = await tenor.search(searchTerm); | ||
| const result = await tenor.search(searchTerm || pickerContext.initialSearchTerm); |
There was a problem hiding this comment.
Initially I thought about adding the logic to the TenorManager but since this is the actual place that triggers the search it was looking better to leave this logic here.
| searchTerm: string; | ||
| showTrending: boolean; | ||
| initialSearchTerm: string; |
There was a problem hiding this comment.
I'm using VS code default format, it was odd to the previous code, seems okay now
There was a problem hiding this comment.
Thanks, i will work on this kind of issues #34
| export type PickerContextSettings = { | ||
| initialSearchTerm: string; | ||
| } |
There was a problem hiding this comment.
following the pattern from useSettings
There was a problem hiding this comment.
initialSearchTerm implementation is just a duplicate of #32 at this point. But I would gladly merge these typo fixes. Please remove initialSearchTerm implementation from here but keep other fixes.
|
@MrBartusek not the same, it still has a different behavior related to have input value empty + still search relevant gifs, you can see the storybook, would you rather the other behavior? |
Oh, I overlooked that. In that case, it's just a questionable UX choice. A user can see that nothing is being searched for and then they see a search result. I would prefer #32 implementation rather than this one Can you please tell me, does #32 fit your use case? |
|
@MrBartusek Technically so so, it has a worst UX, our common tag used w/ creators is the name of the product, which would make no sense (or irrelevant) to show to the user as a term, they will need to remove the entire term to search something else, whereas this one will friendly change behavior based on users' interaction |
|
Hey! I've just merged #32 and the implementation for the This may be tricky to update this PR specifically since I've implemented new lint rules and caused conflicts in every single file. So I would suggest you either make a new PR with the typo fixes or try to change this one. As for your use case, please add me on discord |
|
@MrBartusek thank you, I'll take a look, lets close this one. |
Based on discussion on this other PR #32 I decided to send a suggestion to have a better UX + fixing some typos.
Behavior:
Search Tenor.initialSearchTerm, added this note to the README docs.