This repository has been archived by the owner on Sep 27, 2024. It is now read-only.
fix(analytics): capture engagement events on children of <a>'s #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpezninjo
changed the title
jpezninjo
commented
Oct 27, 2023
|
|
||
| linkClick.record({ target_url: closestLink.getAttribute('href') || '' }) | ||
|
|
||
| recordEngagement(closestLink) |
There was a problem hiding this comment.
capturing of links engagement happens here
jpezninjo
commented
Oct 30, 2023
| function handleButtonClick(ev: MouseEvent) { | ||
| const eventTarget = ev?.target as Element | ||
| const closestButton = eventTarget.closest('button') | ||
|
|
||
| if (!closestButton) |
There was a problem hiding this comment.
This guard is a functional change. Currently, handleButtonClick captures engagement events on any element. Adding this guard is needed to prevent duplicate events from both here and handleLinkClick for clicks on links.
cc @wtfluckey
jpezninjo
commented
Oct 30, 2023
| @@ -33,24 +33,41 @@ export default defineNuxtPlugin((nuxtApp) => { | |||
| } | |||
| } | |||
|
|
|||
| function recordEngagement(element: Element) { | |||
There was a problem hiding this comment.
broke out the code in handleButtonClick to this re-usable function
There was a problem hiding this comment.
used early returns instead of if-statements and optional chaining
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal: clicking on any part of a link should trigger engagement events.
Currently, our code is not setup to handle clicks on children of an anchor
<a>tag.This PR is a follow up improvement to #67 (comment)
To Do:
Image showing the bounding box of a nested
<span>in an<a>