This repository has been archived by the owner on Sep 27, 2024. It is now read-only.
fix(discover): add line limits to recommendations over character limits [MS-59] #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthony-liddle
commented
Oct 11, 2023
| return str | ||
| return `${str.slice(0, str.lastIndexOf(' ', maxLen))}...` | ||
| } | ||
|
|
anthony-liddle
commented
Oct 11, 2023
| display: -webkit-box; | ||
| -webkit-line-clamp: 3; | ||
| -webkit-box-orient: vertical; | ||
| } |
There was a problem hiding this comment.
Putting all this CSS here instead of using UnoCSS for readability.
All these pieces are needed for clamping the line, so instead of breaking it up into different locations it felt best to colocate it all here.
The p tag had an existing line-height of 1.6, so I'm explicitly declaring it here so it makes sense with the max-height.
wtfluckey
approved these changes
Oct 11, 2023
jpezninjo
approved these changes
Oct 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Update text limits from character limits to line limits
To Do:
Implementation Decisions
The request was to remove all limits from the Title, as that is automatically truncated on the server to 255 characters.
The description needs to be clamped to a maximum of 3 lines.