Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ 重构订阅平台 Twitter 的代码 #197

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

FrozenYogurtPuff
Copy link

  • ✨ 添加新的订阅平台 Twitter #193 的基础上参考 Review 进行重构
  • 复用 SchedulerConfig 中的 http_client
  • client 中配置 headers 与 cookie,减少无关变量
  • 重命名请求函数 gotraw_request
  • 修改了对应的测试用例

@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Base: 79.68% // Head: 81.00% // Increases project coverage by +1.32% 🎉

Coverage data is based on head (7689eb5) compared to base (cce34ab).
Patch coverage: 93.63% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #197      +/-   ##
==========================================
+ Coverage   79.68%   81.00%   +1.32%     
==========================================
  Files          46       47       +1     
  Lines        2722     2985     +263     
==========================================
+ Hits         2169     2418     +249     
- Misses        553      567      +14     
Flag Coverage Δ
smoke-test 81.00% <93.63%> (+1.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/plugins/nonebot_bison/platform/twitter.py 93.63% <93.63%> (ø)
src/plugins/nonebot_bison/send.py 79.36% <0.00%> (-2.12%) ⬇️
src/plugins/nonebot_bison/scheduler/scheduler.py 71.91% <0.00%> (+4.49%) ⬆️
...rc/plugins/nonebot_bison/utils/scheduler_config.py 94.44% <0.00%> (+5.55%) ⬆️
src/plugins/nonebot_bison/scheduler/aps.py 100.00% <0.00%> (+5.55%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant