100 Gold Moon Weapon Skills #303

Groovman · 2019-07-14T16:48:50Z

Checklist

TODO: collect ougiRatio info as main weapon for future update (WON'T implement in this PR)

Added the 100 Gold Moon weapon skills that were possible to be calculated. I don't know if applying a
damage limit up to the damage calculations where crit ratio is greater 1.0 would result in a wrong calculation, I assume it would, because of that crit cap up is not implemented.

# Conflicts: # src/global_logic.js

Updated how SuperAccuracy works

Groovman · 2019-07-28T10:08:16Z

This is now at the best possible state aka finished.

kei-gbf · 2019-07-28T10:31:17Z

Groovman · 2019-07-28T11:10:49Z

[ ] is it possible to change ougi ratio and limit values for Freikugel main weapon ?

TODO in another PR after Take LimitValues/DamageLimit out of damage calculation function #312

Would be possible, but would be as bad as a solution as we currently have with ougi cap up skills for eternals.

This does not requires to implement all skills of them. it's just as task

collect not-implemented skills as TODO then put the list in PR comment

All skills that are left out are skill related or fight state related like is in break or depending on the HP of the enemy boss

kei-gbf · 2019-07-28T11:47:59Z

Can you paste those info in PR comment.

### Checklist
- [ ] [Excalibur](https://gbf.wiki/Excalibur)
- [ ] [Damascus Knife](https://gbf.wiki/Damascus_Knife)
- [ ] [Gae Bulg](https://gbf.wiki/Gae_Bulg)
- [ ] [Mjolnir](https://gbf.wiki/Mjolnir)
- [ ] [Caduceus](https://gbf.wiki/Caduceus)
- [ ] [Freikugel](https://gbf.wiki/Freikugel)
- [ ] [Sky Piercer](https://gbf.wiki/Sky_Piercer)
- [ ] [Hercules](https://gbf.wiki/Hercules)
- [ ] [Ullikummi](https://gbf.wiki/Ullikummi)
- [ ] [Ameno Habakiri](https://gbf.wiki/Ameno_Habakiri)

### Not Implement (TODO/WON'T DO)

- WON'T: Golden Advent, require enemy status: "break" Motocal does not support now.
- WON'T: Slayer of Immortals, Motocal does not support ability damage
- WON'T: Slaysnake's Myth, not implement "stackable" when multi attacks?
  - [ ] "skill" have now Info field, like Akasha sword has numbers of enemy debuff
        Habakiri can have the extra info stack level?

break_everything is Apocalyptic Power ? (the fist, TA 100% skill)
- I just wonder where the name from.
When main weapon (MC only), we can ignore comb[i] * ?

kei-gbf · 2019-07-28T11:50:46Z

Would be possible, but would be as bad as a solution as we currently have with ougi cap up skills for eternal

I see, it's weapon specific info not by skill.

kei-gbf · 2019-07-28T11:59:12Z

no result.js update for new skill fields, display the skill amount ?
- I could check "TA: 100%" by "break_everything" skill
  but can't see "superTA" fields in the result

Groovman · 2019-07-28T11:59:56Z

break_everything is Apocalyptic Power ? (the fist, TA 100% skill)

I just wonder where the name from.

https://translate.google.de/#view=home&op=translate&sl=auto&tl=en&text=%E4%B8%87%E7%89%A9%E3%82%92%E7%A0%95%E3%81%8F%E5%89%9B%E6%8A%80

When main weapon (MC only), we can ignore comb[i] * ?

Technically yes, I left it in because I don't know how aux slot would affect it.

kei-gbf · 2019-07-28T12:09:17Z

Ah google translation
I feel the original English skill name is better for new skill IDs
Although some of legacy skills has Japanese(roma-ji),
it required convert twice, Japanese hiragana and convert to roma-ji (to be ID, ASCII only token)

how about "apocalyptic_power", follow English wiki names.

kei-gbf · 2019-07-28T13:08:50Z

stack or take the max value ? critialDamageLimit ... currently no ways to proof/validate this?
- rigaiBishojo had the party buff, both main weapon skill, so not conflict in game.
- but it can happen in Motocal

kei-gbf · 2019-07-28T13:17:53Z

royal_path ougi limit should be add to different field ?

kei-gbf · 2019-07-28T13:24:46Z

wait ... or I misunderstand, I read the verification Excalibur
add to the same field with Seofon's support.

is this another issue?
~~current Motocal ougi limit code does stack all to the same field ? not separate skill and other?~~

kei-gbf · 2019-07-30T04:30:59Z

https://gbf.wiki/Excalibur ref 2 said

シエテサポアビ等と同枠加算、秘奥必殺等武器スキルと別枠乗算

ougi Damage Up, add to the same field with Seofon support etc, multiply with Hissatsu,Hiou
ougi Damage Limit, maybe Exceed category and under the 30%/60% maximum limit ?
- this requires the verification, I forgot where I saw in twitter.

~~Motocal does not support the multiply field for ougi damage up ? I could not find.~~

Groovman · 2019-07-30T18:33:33Z

ougiDamageSkill is weapon skills, ougiDamageExceptSkill is aadditional ougi buffs like Seofon support skill and at the end Excalibur is added via the superOugiDamage.

var ougiDamageUP = (1.0 + ougiDamageSkill) * (1.0 + ougiDamageExceptSkill) - 1.0;
Weapon and Skills is then multiplied here.

ougi Damage Limit, maybe Exceed category and under the 30%/60% maximum limit?
this requires the verification, I forgot where I saw in twitter.

I do not think that the limit up is on the Exceed mod because The skill names is unique and that most often meant unique mod for that weapon and most elements have Exceed limit up weapons which would make a pay 2 win weapon bad if they would not stack and fill the limit in one go. I can ask around tomorrow if some whale has a Excalibur and knows if it stacks, but it would be strange to me if it does not stack.

kei-gbf · 2019-07-30T22:21:01Z

Weapon and Skills is then multiplied here.

Ok, I found I was seeing it for "Limit"

ougi damage Limit (requires verification)
- 30% limit Exceed ?
  - if it was Exceed then Excalibur 30% equals the field limit 30%
    there was no need to care stack or not.
- 60% limit (Exceed + Magna + Normal) ?
- now no limit, unique field, then multiple number of weapon will over the limit.
  - can be fixed by remove comb[i] * or have the field limit.
  - ougi damage up as well

Groovman · 2019-07-31T06:41:55Z

Weapon and Skills is then multiplied here.

Ok, I found I was seeing it for "Limit"

ougi damage Limit (requires verification)

30% limit Exceed ?

if it was Exceed then Excalibur 30% equals the field limit 30%
there was no need to care stack or not.

60% limit (Exceed + Magna + Normal) ?

now no limit, unique field, then multiple number of weapon will over the limit.

can be fixed by remove comb[i] * or have the field limit.

ougi damage up as well

Is on exceed aka excelsior. I update it in a few mins.

…up is normal

kei-gbf · 2019-07-31T17:51:15Z

PR does not require to implement the perfect, hold on the tasks for future.
I'll check the confirmed info checkbox, with verification source.
if no sources then write down the current implementation info.

EDIT Update skill ID names

coeff is for display, passing values to result.js
coeff accuracy does nothing currently.

TODO: display accuracy/accuracyWithoutCritical skill values
- if not implement in this PR, we can add this task to TODO list in PR comment.

Minor coding checks

Missing semicolons: "criticalDamageLimit" at "stab_kill", "battle_god"

Off Topic (not request):

I've thought during in review, it's useful for debug
if ougiDamageUp displayed "ougiDamageSkill" and "ougiDamageExceptSkill"

kei-gbf · 2019-09-29T10:59:07Z

review tasks

done reviewing 6 skills
~~check status values~~ no need, status was not changed

#331 will implement filtering feature by "series"
Can this PR add "series" field for armData ? or should be in #331 ?

kei-gbf

status value check was ok, no need to check it was not changed.
patch add only skill implementations.

Uncompleted task (TODO in another PR)

~~display accuracyDebuff (result.js)~~
- EDIT: Accuracy is displayed as a debuff similar to ATKDebuff
add series Update series field in arm txt / Add more filtering feature for weapon list #331
EDIT: victorys_promise is now implemented so in Add Turn Counter #342 it can be integrated with the turn buff
INFO: (Gae Bulg) Most Websites show 900/5, one is 800/7 and one is 900/7, 900/5 is avg

need check stack for slaysnakes_myth II

kei-gbf · 2019-10-19T07:44:49Z

スペリオルシリーズのスキル実装(まとめ)

主にメイン装備時。(4凸時のスキル表記省略)

エクスカリバー
- 王道を征く者
  - HPが高いほど奥義ダメージUP (superOugiDamage)
  - 上限上昇イクシード枠
ゲイボルグ
- 必勝の誓い最大効果時 (経過ターンは Add Turn Counter #342 実装後に対応)
- 一刺一殺クリティカル/クリティカル時上限
  - ※ 効果量は諸説有。情報元により異なる
ミョルニル
戦神の打擲確定TA + 追撃
方天画戟
- 万物を砕く剛技
  - クリティカル/クリティカル時上限
  - 命中率の実装
天羽々斬
- 戮蛇の神刀
  - 累積レベルは固定値で入力可 ~~(戮蛇の神刀 II の累積レベル入力は対応待ち)~~

kei-gbf · 2019-10-19T07:49:17Z

src/global_logic.js

+                                totals[key][stype] = Math.max(totals[key][stype], 10.0 * arm[skillkey + "Detail"]);
+                                if (amount == "II") {
+                                    totals[key]["normalDamageLimit"] += 0.10;
+                                    totals[key]["exceedOugiDamageLimit"] += 0.10;


exceed ??

I forgot this topic, I remember the exceed was for Excalibur's skill.

Excalibur and so, go on the Excelsior ougi cap up. They are not unique.

I couldn't find the info exceed for slaysnakes_myth (require verification)

damage limit is also stackable Boost to DMG cap (Stackable)

Excalibur is ok exceed, https://twitter.com/wasavi_v2/status/1051660706171375616
but here review for Ameno Habakiri skill2, I could not find info. then I am not sure this.

ref another damage limit up code is using ougiDamageLimit

// Damage upper limit up system works for both mystery and normal } else if (stype == 'normalDamageLimit') { totals[key]["normalDamageLimit"] += comb[i] * skillAmounts["normalDamageLimit"][amount]; totals[key]["ougiDamageLimit"] += comb[i] * skillAmounts["normalDamageLimit"][amount];

total ougi limit up = buff (omage, ougiDamageLimit, buff etc) x weapons (exceed x normal x magna)
they are different category.

Anything else than Exceed (Excelsior) makes no sense becasue flavour text would mention that it is a primal type skill that it would be affected by the summon type, and 95% + additional stacking buff as unique would make the weapon really really game breaking.

the limit up stackable is as game text said,
and it had extra condition like clariss's field which motocal does not support.
(Can deal big bonus DMG when DMG dealt in one turn reaches a certain amount)
http://graninfo.com/wp2/granbluefantasy/amanohabakiri

攻撃力UP ATK up

連続攻撃発生毎に別枠＋10%(上限100%) (unique, stack Lv x 10% max 100%)

ダメージ上限UP damage limit up

連続攻撃発生毎に＋1%(上限10%) (stack Lv x 1% max 10%)

so I think,

totals[key]["normalDamageLimit"] += Math.max(0.10, 0.01 * arm[skillkey + "Detail"]);

I don't know about the ougi limit implementation.

no affected by the summon ... ok

limit up also gain ougi limit too ... ok

but exceed or other category ... don't know
I've shown was just other limit up skill implementation did not use Exceed category.
I don't have the info to confirm the implementation is correct or not.
Can you share the info source if you had.

or just to pass the review in this PR, can you add a note comment at the Exceed line
if we don't have the details, pass the review is other choice.
EDIT: I mean, leave the review for future, I'll approve without confirm this point.

// XXX: Verification Required

one different point I noticed now
the skill is implemented as Add stackable buff when multiple attacks.
unlike other skills which affect to internal state directly.

so other possibility: "damageLimitBuff", "ougiDamageLimitBuff" ?

damageLimitBuff: djeetaBuffList["personalDamageLimitBuff"],
ougiDamageLimitBuff: djeetaBuffList["personalOugiDamageLimitBuff"],

Mapped to EMP UI :D

src/global_const.js

src/global_logic.js

# Conflicts: # armData.json # src/global_const.js # src/global_logic.js # txt_source/armData-ssr.txt

# Conflicts: # src/global_logic.js # src/result.js

# Conflicts: # armData.json # src/global_logic.js # txt_source/armData-ssr.txt

Groovman · 2020-03-09T19:30:59Z

Please merge, it is tested for months now.

kei-gbf · 2020-03-10T07:07:47Z

@Groovman
There was 1 unresolved conversation,
Ameno Habakiri 's limit up, it's implemented as buff, unlike other weapon's skill.
the result will be different by add or mul, and the limit of skill amount.
So, I suggested this to mark as no proof implementation, by adding the source comment.
at least until we get the verification.

kei-gbf

I agree to merge this PR, the rest issue is low priority we can fix it later.

Groovman · 2020-03-14T11:51:48Z

Will add a comment to it "Verified by weapon users, not by wiki"

Groovman and others added 11 commits July 14, 2019 18:32

Added 100 Gold Moon Weapon Skills

3520a96

Extend buff level list for gold moon ougi crit calculation

1b897af

Fix charts missing because of typo and nan values

972ac87

Move accuracy debuff for Mjolnir behind the limit calculation.

ed791e8

Merge branch 'master' into gm100_skills

6e6ca6d

Merge remote-tracking branch 'remotes/origin/master' into gm100_skills

66b7054

# Conflicts: # src/global_logic.js

Add critical cap up for Gae Bulg and Mjolnir.

a7b4204

Merge branch 'master' into gm100_skills

f0249e6

Merge branch 'master' into gm100_skills

7c3bdb7

Merge branch 'master' into gm100_skills

5ba581c

Moved accuracy outside the damage function

396246e

Updated how SuperAccuracy works

Groovman added the enhancement label Jul 28, 2019

Groovman and others added 2 commits July 31, 2019 09:03

Corrected Damage Limit mods, Ougi cap up is on Exceed and Damage cap …

04204fa

…up is normal

Merge branch 'master' into gm100_skills

dcde069

Merge branch 'master' into gm100_skills

8e70176

Groovman added 3 commits October 14, 2019 19:49

Merge branch 'master' into gm100_skills

86eebae

Merge branch 'master' into gm100_skills

f4641df

Fix failed failed armdata merge

0ffe3bd

kei-gbf previously approved these changes Oct 19, 2019

View reviewed changes

kei-gbf reviewed Oct 19, 2019

View reviewed changes

src/global_const.js Show resolved Hide resolved

Addd number of stacks to slaysnakes_mythII

3a828a4

kei-gbf reviewed Oct 20, 2019

View reviewed changes

src/global_logic.js Show resolved Hide resolved

Groovman added 9 commits October 21, 2019 00:41

Merge branch 'master' into gm100_skills

f0b50e0

Merge branch 'master' into gm100_skills

28f0d5c

Merge remote-tracking branch 'remotes/origin/master' into gm100_skills

917fc23

# Conflicts: # armData.json # src/global_const.js # src/global_logic.js # txt_source/armData-ssr.txt

Merge branch 'master' into gm100_skills

4148edd

Merge remote-tracking branch 'remotes/origin/master' into gm100_skills

a4793b4

# Conflicts: # src/global_logic.js # src/result.js

Merge branch 'master' into gm100_skills

17a2cba

fix translation

f89c430

Merge remote-tracking branch 'remotes/origin/master' into gm100_skills

3e01204

# Conflicts: # armData.json # src/global_logic.js # txt_source/armData-ssr.txt

Merge branch 'master' into gm100_skills

ccda5c1

kei-gbf approved these changes Mar 10, 2020

View reviewed changes

kei-gbf mentioned this pull request Mar 10, 2020

Request verification data in granblue #360

Open

2 tasks

Groovman added 2 commits March 14, 2020 13:51

Added comment

38e03d0

Merge remote-tracking branch 'groovman/gm100_skills' into gm100_skills

acadcc5

Groovman merged commit b301f5c into MotocalDevelopers:master Mar 14, 2020

Groovman deleted the gm100_skills branch March 14, 2020 14:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

100 Gold Moon Weapon Skills #303

100 Gold Moon Weapon Skills #303

Groovman commented Jul 14, 2019 •

edited by kei-gbf

Loading

Groovman commented Jul 28, 2019

kei-gbf commented Jul 28, 2019 •

edited

Loading

Groovman commented Jul 28, 2019

kei-gbf commented Jul 28, 2019

kei-gbf commented Jul 28, 2019

kei-gbf commented Jul 28, 2019 •

edited

Loading

Groovman commented Jul 28, 2019 •

edited

Loading

kei-gbf commented Jul 28, 2019 •

edited

Loading

kei-gbf commented Jul 28, 2019

kei-gbf commented Jul 28, 2019

kei-gbf commented Jul 28, 2019 •

edited

Loading

kei-gbf commented Jul 30, 2019 •

edited

Loading

Groovman commented Jul 30, 2019

kei-gbf commented Jul 30, 2019 •

edited

Loading

Groovman commented Jul 31, 2019

kei-gbf commented Jul 31, 2019 •

edited

Loading

kei-gbf commented Sep 29, 2019 •

edited

Loading

kei-gbf left a comment •

edited

Loading

kei-gbf commented Oct 19, 2019 •

edited

Loading

kei-gbf Oct 19, 2019

Groovman Oct 19, 2019 •

edited

Loading

kei-gbf Oct 19, 2019

kei-gbf Oct 20, 2019

Groovman Oct 20, 2019 •

edited

Loading

kei-gbf Oct 21, 2019

kei-gbf Oct 21, 2019 •

edited

Loading

kei-gbf Oct 21, 2019 •

edited

Loading

Groovman Oct 22, 2019

Groovman commented Mar 9, 2020

kei-gbf commented Mar 10, 2020

kei-gbf left a comment

Groovman commented Mar 14, 2020

100 Gold Moon Weapon Skills #303

100 Gold Moon Weapon Skills #303

Conversation

Groovman commented Jul 14, 2019 • edited by kei-gbf Loading

Checklist

TODO: collect ougiRatio info as main weapon for future update (WON'T implement in this PR)

Groovman commented Jul 28, 2019

kei-gbf commented Jul 28, 2019 • edited Loading

Checklist

weapons

skills

Groovman commented Jul 28, 2019

kei-gbf commented Jul 28, 2019

kei-gbf commented Jul 28, 2019

kei-gbf commented Jul 28, 2019 • edited Loading

Groovman commented Jul 28, 2019 • edited Loading

kei-gbf commented Jul 28, 2019 • edited Loading

kei-gbf commented Jul 28, 2019

kei-gbf commented Jul 28, 2019

kei-gbf commented Jul 28, 2019 • edited Loading

kei-gbf commented Jul 30, 2019 • edited Loading

Groovman commented Jul 30, 2019

kei-gbf commented Jul 30, 2019 • edited Loading

Groovman commented Jul 31, 2019

kei-gbf commented Jul 31, 2019 • edited Loading

kei-gbf commented Sep 29, 2019 • edited Loading

kei-gbf left a comment • edited Loading

Choose a reason for hiding this comment

Uncompleted task (TODO in another PR)

kei-gbf commented Oct 19, 2019 • edited Loading

スペリオルシリーズのスキル実装(まとめ)

kei-gbf Oct 19, 2019

Choose a reason for hiding this comment

Groovman Oct 19, 2019 • edited Loading

Choose a reason for hiding this comment

kei-gbf Oct 19, 2019

Choose a reason for hiding this comment

kei-gbf Oct 20, 2019

Choose a reason for hiding this comment

Groovman Oct 20, 2019 • edited Loading

Choose a reason for hiding this comment

kei-gbf Oct 21, 2019

Choose a reason for hiding this comment

kei-gbf Oct 21, 2019 • edited Loading

Choose a reason for hiding this comment

kei-gbf Oct 21, 2019 • edited Loading

Choose a reason for hiding this comment

Groovman Oct 22, 2019

Choose a reason for hiding this comment

Groovman commented Mar 9, 2020

kei-gbf commented Mar 10, 2020

kei-gbf left a comment

Choose a reason for hiding this comment

Groovman commented Mar 14, 2020

Groovman commented Jul 14, 2019 •

edited by kei-gbf

Loading

kei-gbf commented Jul 28, 2019 •

edited

Loading

kei-gbf commented Jul 28, 2019 •

edited

Loading

Groovman commented Jul 28, 2019 •

edited

Loading

kei-gbf commented Jul 28, 2019 •

edited

Loading

kei-gbf commented Jul 28, 2019 •

edited

Loading

kei-gbf commented Jul 30, 2019 •

edited

Loading

kei-gbf commented Jul 30, 2019 •

edited

Loading

kei-gbf commented Jul 31, 2019 •

edited

Loading

kei-gbf commented Sep 29, 2019 •

edited

Loading

kei-gbf left a comment •

edited

Loading

kei-gbf commented Oct 19, 2019 •

edited

Loading

Groovman Oct 19, 2019 •

edited

Loading

Groovman Oct 20, 2019 •

edited

Loading

kei-gbf Oct 21, 2019 •

edited

Loading

kei-gbf Oct 21, 2019 •

edited

Loading