item: Implement CoinCollect2D

[german77]

One of the biggest classes for coin types. This one utilizes most of the previous implementations.

---

This change is 

[MonsterDruide1]

Blocked by ... one of the open PRs, I don't remember which one. If it's not merged today, ask again and I'll look up the exact ID.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @german77)

---

src/Item/CoinCollect2D.cpp line 45 at r1 (raw file):

    rs::createCoinCollectHolder(this);
    CoinCollectHolder* holder =
        (CoinCollectHolder*)al::getSceneObj(this, SceneObjID_CoinCollectHolder);

(to be introduced in some of the open PRs, not sure which one)

Suggestion:

    CoinCollectHolder* holder =
        al::getSceneObj<CoinCollectHolder>(this, SceneObjID_CoinCollectHolder);

---

src/Item/CoinCollect2D.cpp line 49 at r1 (raw file):

    GameDataHolderAccessor gameData(this);

    if (!GameDataFunction::isGotCoinCollect(gameData, initInfo)) {

Suggestion:

    if (!GameDataFunction::isGotCoinCollect(this, initInfo)) {

---

src/Item/CoinCollect2D.cpp line 54 at r1 (raw file):

        makeActorAlive();
        CoinCollectWatcher* watcher =
            (CoinCollectWatcher*)al::getSceneObj(this, SceneObjID_CoinCollectWatcher);

Suggestion:

        CoinCollectWatcher* watcher =
            al::getSceneObj<CoinCollectWatcher>(this, SceneObjID_CoinCollectWatcher);

---

src/Item/CoinCollect2D.cpp line 73 at r1 (raw file):

        const char* archiveName = rs::getStageCoinCollect2DEmptyArchiveName(this);
        CoinCollectWatcher* watcher =
            (CoinCollectWatcher*)al::getSceneObj(this, SceneObjID_CoinCollectWatcher);

Suggestion:

        CoinCollectWatcher* watcher =
            al::getSceneObj<CoinCollectWatcher>(this, SceneObjID_CoinCollectWatcher);

---

src/Item/CoinCollect2D.cpp line 152 at r1 (raw file):

        al::startAction(this, "Got");
        CoinCollectWatcher* watcher =
            (CoinCollectWatcher*)al::getSceneObj(this, SceneObjID_CoinCollectWatcher);

Suggestion:

        CoinCollectWatcher* watcher =
            al::getSceneObj<CoinCollectWatcher>(this, SceneObjID_CoinCollectWatcher);

[german77]

Needs #250 to compile properly

[MonsterDruide1]

Yes, that's the one I meant!

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion (waiting on @german77)

---

data/odyssey_functions.csv line 0 at r4 (raw file):
Also, add this class to the ActorFactory.

[german77]

Reviewable status: 3 of 5 files reviewed, 1 unresolved discussion (waiting on @MonsterDruide1)

---

data/odyssey_functions.csv line at r4 (raw file):

Previously, MonsterDruide1 wrote…

Also, add this class to the ActorFactory.

Done.