-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
item: Implement CoinCollectDummy #221
item: Implement CoinCollectDummy #221
Conversation
eff3f65
to
bd9b269
Compare
bd9b269
to
e7dd694
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @german77)
src/Item/CoinCollectDummy.h
line 11 at r1 (raw file):
class CoinCollectDummy : public al::LiveActor { public: CoinCollectDummy(const char*);
Suggestion:
CoinCollectDummy(const char* name);
src/Item/CoinCollectDummy.h
line 13 at r1 (raw file):
CoinCollectDummy(const char*); void init(const al::ActorInitInfo&) override;
Suggestion:
void init(const al::ActorInitInfo& initInfo) override;
src/Item/CoinCollectDummy.h
line 16 at r1 (raw file):
void appear() override; void appearHint(const sead::Vector3f&);
Suggestion:
void appearHint(const sead::Vector3f& position);
src/Item/CoinCollectHintState.h
line 12 at r1 (raw file):
public: CoinCollectHintState(al::LiveActor*); ~CoinCollectHintState();
Remove this - it appears to exist, but that's only because it's auto-generated by the compiler. Not specifying it here is the right way to go.
(also, it would've required override
otherwise)
src/Item/CoinCollectDummy.cpp
line 19 at r1 (raw file):
struct { NERVE_MAKE(CoinCollectDummy, Hint); } NrvCoinCollectDummy;
Suggestion:
NERVES_MAKE_STRUCT(CoinCollectDummy, Hint);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 4 files reviewed, 5 unresolved discussions (waiting on @MonsterDruide1)
src/Item/CoinCollectHintState.h
line 12 at r1 (raw file):
Previously, MonsterDruide1 wrote…
Remove this - it appears to exist, but that's only because it's auto-generated by the compiler. Not specifying it here is the right way to go.
(also, it would've requiredoverride
otherwise)
Done.
src/Item/CoinCollectDummy.cpp
line 19 at r1 (raw file):
struct { NERVE_MAKE(CoinCollectDummy, Hint); } NrvCoinCollectDummy;
Done.
src/Item/CoinCollectDummy.h
line 11 at r1 (raw file):
class CoinCollectDummy : public al::LiveActor { public: CoinCollectDummy(const char*);
Done.
src/Item/CoinCollectDummy.h
line 13 at r1 (raw file):
CoinCollectDummy(const char*); void init(const al::ActorInitInfo&) override;
Done.
src/Item/CoinCollectDummy.h
line 16 at r1 (raw file):
void appear() override; void appearHint(const sead::Vector3f&);
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @german77)
This is used in HelpAmiiboCoinCollect. I'm stuck in that one so for now I will implement all coin collect variants.
This change is