-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--trace
option & New parsing with optional output file argument
#18
Conversation
…l output file, remove backwards-compatibility syntax
…) & Fix SEGFAULTs caused by unexpected number of arguments
Seems fine to me, I'll test it a bit tomorrow and let you know :) |
@MonoS Did you come around to testing this? Let me know if you want me to change something. |
Yeah, i've put some comment in your code, i can see them in this PR before your latest comment. |
Oh, don't know why but I can't see those unfortunately ¯\(ツ)/¯ |
That's probably because I don't know how to use github :) Anyway:
In any case I can see the code review from this link https://github.com/MonoS/SupMover/pull/18/files/8968b7ce51e5384b9684d1a867d82b3ef87393cb |
That's fine, I'm not familiar with code review on GitHub either :)
That was on purpose since it's part of the old syntax and thus doesn't need to be backwards compatible. Agreed on the other two points! |
Should be fixed now |
Merged, thank you :) |
See discussion: #17 (comment)
--trace
option for printing structure and contents of segments--trace
)