-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: add javascript tokenizer #4
base: master
Are you sure you want to change the base?
Conversation
- copied from https://git.io/voeEf - works on both file and function level
const outputFile = function(functionTokens) { | ||
functionTokens.forEach((f) => { | ||
//console.log("===") | ||
console.log(f) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's specify an output file and print our results to that file. Sometimes developers might want to debug using plain old school console.log approach and so let's use console only for the debug or auxiliary info.
Hey Jakub,
Yes, we should do that. For now, let's note it down in a new ticket.
Thanks again for the great work |
Hi @saini, thanks for the code-review, I agree with most of the comments. I'll polish the code a bit, update the MR and also file some ideas and issues I had with SourcererCC in general. |
Sounds good 👍 |
962360b
to
49cd0c2
Compare
Hey,
I am working (in coordination with @crista) on a javascript tokenizer for SourcererCC. This is the first working concept written in
node.js
, so we can test it out and communicate better.This is a Work In Progress.
I don't think this is good enough to be merged yet, we should think about better way to manage the tokenizer "modules" in SourcererCC. It would be great to be able to switch between tokenizers in the the
.properties
config and to have (at least roughly) the same api. What do you think? MaybeI will post updated version with better preprocessing of JS files and a script for generically running the tokenization.