Update lua api

[robincodex]

• Add generics to CEntities
• Fix purchaser type of CreateItem
• Change return type of CBaseEntity.IsPlayerController and CBaseEntity.IsPlayerPawn

[robincodex]

@Perryvw Hi, Can you merge this pr? I also have a PR on the dota-data

[Perryvw]

Sorry @robincodex but after discussing this with DG, we decided the generic entity types are more dangerous than just casting, and fundamentally they are the same. With explicit casts you can at least see in your code where you are making some dangerous assumption, with the generic functions like you did, that becomes at lot less clear. You can of course still make the generic versions in your own code as helper functions or maybe even with interface merging.

The IsPlayerController changes are fine so I left those in.

[robincodex]

Sorry @robincodex but after discussing this with DG, we decided the generic entity types are more dangerous than just casting, and fundamentally they are the same. With explicit casts you can at least see in your code where you are making some dangerous assumption, with the generic functions like you did, that becomes at lot less clear. You can of course still make the generic versions in your own code as helper functions or maybe even with interface merging.

The IsPlayerController changes are fine so I left those in.

Ok, no problem