Skip to content

Commit

Permalink
fix(lint): start implementing lint fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
thelooter committed Nov 5, 2024
1 parent ff9cfe8 commit 17e14aa
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 11 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,17 +15,17 @@ jobs:
strategy:
matrix:
node-version:
- 18
- 20
- lts/*
- latest
- "18"
- "20"
- "lts/*"
- "latest"
steps:
- uses: actions/checkout@v4

- name: Get PNPM version from package.json
id: pnpm-version
shell: bash
run: echo "pnpm_version=$(node -p 'require(`./package.json`).engines.pnpm')" >> $GITHUB_OUTPUT
run: echo "pnpm_version=$(node -p "require('./package.json').engines.pnpm")" >> "$GITHUB_OUTPUT"

- name: Install pnpm
uses: pnpm/action-setup@v4
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/lint.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@ on:
branches:
- main

permissions: {}
permissions:
contents: read

jobs:
lint:
runs-on: ubuntu-latest
Expand Down
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ Before you start contributing, ensure you have the following prerequisites insta

- Follow the existing coding style and formatting used in the documentation repository.
- Ensure your changes are consistent with the overall tone and voice of the documentation.
- Make use of Vitepress's built-in features, such as frontmatter, custom components, and markdown extensions, where appropriate.
- Make use of Vitepress's built-in features, such as frontmatter, custom components, and Markdown extensions, where appropriate.
- Write clear and concise documentation that is easy for users to understand.

### Code blocks
Expand All @@ -103,7 +103,7 @@ specify blocks for multiple languages. Use the following syntax:

## Vitepress Markdown Extensions

Vitepress provides a variety of markdown extensions that can be used to enhance the documentation.
Vitepress provides a variety of Markdown extensions that can be used to enhance the documentation.
You can find a list of available extensions in the [Vitepress documentation](https://vitepress.dev/guide/markdown).

## Thank You
Expand Down
6 changes: 3 additions & 3 deletions docs/en/contribution/maintainers/pr_guide.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ and attract new people to help drive this project forward!

:::

We use [Github Labels](https://docs.github.com/en/issues/using-labels-and-milestones-to-track-work/managing-labels)
We use [GitHub Labels](https://docs.github.com/en/issues/using-labels-and-milestones-to-track-work/managing-labels)
to automatically tag PRs with a version number on merge. This removes the tedious work of keeping version numbers up
to date across several PRs at a time and eliminate Human error. The following custom labels, all of them following the
pattern of `release/*`, are used by Mockbukkit:
Expand All @@ -22,7 +22,7 @@ pattern of `release/*`, are used by Mockbukkit:
|----------------------------------------------|:----------------------|:--|:---------------------------------------|
| <Badge type="danger" text="release/major"/> | Major Version (X.0.0) | | Only used for breaking changes |
| <Badge type="warning" text="release/minor"/> | Minor Version (0.X.0) | | New Features |
| <Badge type="tip" text="release/patch"/> | Patch Version (0.0.X) | | Bug Fixes |
| <Badge type="tip" text="release/patch"/> | Patch Version (0.0.X) | | Bugfixes |
| <Badge type="info" text="release/none"/> | None (-) | | Method Stubs or non code related fixes |

As you can probably tell, this project uses [Semantic Versioning](https://semver.org/).
As you can probably tell, this project uses [Semantic Versioning](https://semver.org/).

0 comments on commit 17e14aa

Please sign in to comment.