Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update this folk with upstream google/transit repo #69

Closed
wants to merge 7 commits into from

Conversation

isabelle-dr
Copy link

@isabelle-dr isabelle-dr commented Apr 24, 2024

Update this fork with upstream google/transit repo

isabelle-dr and others added 7 commits January 15, 2024 14:26
* Add dataset publishing in index

* Fix link

* Clarify stop_timezone description

* Make references to other files consistent

* fix link in Dataset Publishing Guidelines

* Fix links
* Add Trip-Modification, make shape non-experimental

Fix typo

Add images

Update image width

Add newlines

Add newlines

Update images

Italic for image description

Update SLO

travel_time_to_stop is optional

Proto : all feild optional

Add references to GTFS-Static

* Create a page for TripModifications entities for consistency with TU and VP

* Clarify providing TUs for modified trips and ReplacementStop time interpolation

Less strong requirement to interpolate

* Fix first_stop_reference.png not having the right image + optimize image size.

* Fix optional/require for Stop message

* Clarify behaviour and linkage to TripUpdates

* Apply Modification clarification proposed changes

Co-authored-by: Paul Swartz <[email protected]>

* Use ModifiedTripSelector instead of concatenation of IDs

Update langage

Update namign

* Add details on behavior when  is provided

* Remove modifications_id

* Fix after comments from @bdferris-v2

* Add note about producer needed the two versions of trip updates

* Fix bad relationship mentionned, + force no other entity when using ModifiedTripSelector

* Changes after Jan 10 call

* Add experimental notices

* Remove mention of stop pattern

* Use stop selector instead of stop sequence only

* Update to end_stop_selector

* Update proto with start/end stop selector

* Add selected trips

* Update reference with SelectedTrips

* Update trip modif doc

* Add last_modified_time

* Add missing start_times in pb

* Fix typos, fix description of selected trips

* Fix typos

Co-authored-by: Nicholas Paun <[email protected]>

* Update reference for clarity

* Clarify and remove duplicated information

* Consistancy

* Revert correctly shape experimental

* Editorial, formatting clarifications

* Apply suggestions from @sam-hickey-ibigroup

Co-authored-by: Sam Hickey <[email protected]>

* Update documentation images with new fields, add source files

* Clarifies behavior of propagated_modification_delay when no stop_time is cancelled

* Remove extra word

* Sync .proto and reference files

---------

Co-authored-by: Nicholas Paun <[email protected]>
Co-authored-by: Paul Swartz <[email protected]>
Co-authored-by: Nicholas Paun <[email protected]>
Co-authored-by: Joshua Fabian <[email protected]>
Co-authored-by: Sam Hickey <[email protected]>
* Add 3 "location" files and booking rules file

* Modify stops.stop_id

* Modify routes.continuous_pickup/drop_off

* Modify stop_times.arrival/departure_time

* Modify stop_times.stop_id

* Add stop_times.location_group_id & location_id

* Modify stop_times.stop_sequence

* Add stop_times.start/end_pickup_drop_off_window

* Modify pickup_type & drop_off_type

* Modify stop_times.continuous_pickup/drop_off

* Add pickup/drop_off_booking_rule_id

* Add "On-demand Service Routing Behavior"

* Modify conditions for start/end_pickup_drop_off_window

* Remove unnecessary table name & editorial changes
* Clarify fare product definition

* fare media clarification / remove desc in amount

Add explicit interaction w/ fare media,
Remove individual explanation in non-primary keys

* Editorial change

* Update gtfs/spec/en/reference.md

Co-authored-by: isabelle-dr <[email protected]>

* Update desc of fare_product_id

Co-authored-by: isabelle-dr <[email protected]>

* Editorial changes for fare_product_id

* change "segments" to "legs"

---------

Co-authored-by: isabelle-dr <[email protected]>
Copy link

@richfab richfab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CLAassistant
Copy link

CLAassistant commented Apr 24, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

✅ isabelle-dr
✅ gcamp
✅ tzujenchanmbd
❌ firestack
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants