Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Update catalog schema #687

Merged
merged 6 commits into from
Jan 16, 2025
Merged

Feat: Update catalog schema #687

merged 6 commits into from
Jan 16, 2025

Conversation

AlfredNwolisa
Copy link
Collaborator

@AlfredNwolisa AlfredNwolisa commented Jan 15, 2025 •
edited
Loading

Summary
This pull request updates the redirect schema in the Mobility Database Catalogs project.

The changes include:

  1. Modifications to the existing redirect & stattic refrence schema type from INT to STRING to improve data handling and validation.
  2. Updates to the relevant Python scripts to align with the new schema type change.
  3. Updated redirect & static_reference ids in the gtfs catalog(realtime & schedule) json files to reflect the changes in schema type.
  4. Updated README file to reflect chnages.

@AlfredNwolisa
Change numeric IDs to strings for redirects and references
c56ec81 
Updated `id` fields in redirects and static references from numbers to strings across multiple schemas, code, tests and documentation.
@AlfredNwolisa AlfredNwolisa changed the title Feat: Update Catalogue Schema Feat: Update catalog schema Jan 15, 2025
@AlfredNwolisa AlfredNwolisa linked an issue Jan 15, 2025 that may be closed by this pull request
[REQUEST] Update redirect schema and operations to add strings #671
Closed
@AlfredNwolisa
Fix ID field types in GTFS source JSON files
bce42e1 
Updated numeric ID fields to string format in two GTFS source JSON files (Athens Public Transit and Exo Trains) to ensure consistency and correct parsing.
@AlfredNwolisa
fix: updated redirect_id & static_reference values from numeric/int t…
d19e9b0 
…ype to string type.
@AlfredNwolisa
fix: updated static_reference values from numeric/int type to string …
5a01b53 
…type.
@AlfredNwolisa
fix
19a803e
@AlfredNwolisa AlfredNwolisa self-assigned this Jan 16, 2025
davidgamez
davidgamez approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AlfredNwolisa AlfredNwolisa merged commit 835101c into main Jan 16, 2025
8 checks passed
@AlfredNwolisa AlfredNwolisa deleted the update-redirect-schema branch January 16, 2025 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidgamez davidgamez davidgamez approved these changes

Assignees

@AlfredNwolisa AlfredNwolisa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[REQUEST] Update redirect schema and operations to add strings
2 participants
@AlfredNwolisa @davidgamez