feat: 1822 flex forbidden pickup type & forbidden drop off type #1936
+167
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qcdyx
changed the title
|
This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: |
jcpitre
reviewed
Jan 9, 2025
| entity.endPickupDropOffWindow())); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
You should maybe add a shouldValidate method that allows skipping the validate call as an optimisation.
See for example:
StopTimesShapeDistTraveledPresenceValidator.java
And here is the PR where this feature was added: #1875
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Closes #1822
Closes #1818
Expected behavior:
Display forbidden pickup/ drop off notice if conditions met.
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle testto make sure you didn't break anything