Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: build & publish linux/arm64 Docker images #1367

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

ci: build & publish linux/arm64 Docker images #1367

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0335bf0
CI: build & publish linux/arm64 Docker images
derhuerst Mar 30, 2023
2c1e14e
test "Docker image" CI workflow on docker-arm64 branch [drop]
derhuerst Apr 19, 2023
53577a7
Merge branch 'master' into docker-arm64
davidgamez Jun 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .github/workflows/docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,10 @@ name: Docker image

on:
push:
branches: [ master ]
branches:
- master
# todo: revert
- docker-arm64
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should be reverted before merging.

release:
types: [ prereleased, released ]

Expand Down Expand Up @@ -108,6 +111,7 @@ jobs:
build-args: |
VERSION_TAG=${{ steps.prep.outputs.version }}
load: true
platforms: linux/amd64,linux/arm64
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid getting

ERROR: docker exporter does not currently support exporting manifest lists

you'll have to either delete this line, or create a third copy of the docker/build-push-action@v3, (one with load, one with platforms, one with push).

tags: ${{ steps.prep.outputs.tags }}
labels: |
org.opencontainers.image.source=https://github.com/${GITHUB_REPOSITORY,,}.git
Expand All @@ -123,7 +127,9 @@ jobs:
file: ./Dockerfile
build-args: |
VERSION_TAG=${{ steps.prep.outputs.version }}
push: true
# todo: revert
push: false
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should be reverted before merging.

platforms: linux/amd64,linux/arm64
tags: ${{ steps.prep.outputs.tags }}
labels: |
org.opencontainers.image.source=https://github.com/${GITHUB_REPOSITORY,,}.git
Expand Down