Skip to content

Commit

Permalink
chore: upgrade missed e2e upload artifact to v4 (#1937)
Browse files Browse the repository at this point in the history
  • Loading branch information
davidgamez authored Jan 9, 2025
1 parent 9f06d68 commit e1e34ea
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 10 deletions.
16 changes: 8 additions & 8 deletions .github/workflows/acceptance_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,14 @@ concurrency:
jobs:
fail_if_pull_request_is_draft: # Fails in order to indicate that pull request needs to be marked as ready to review to pass.
if: github.event.pull_request.draft == true
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
steps:
- name: Fail if PR is a draft
run: exit 1
pre_ci:
name: Prepare CI environment
if: github.event.pull_request.draft == false # Skip this job and its dependencies if the PR is draft
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
steps:
- name: Checkout Project
uses: actions/checkout@v4
Expand All @@ -53,13 +53,13 @@ jobs:
validate-gradle-wrapper:
if: "!contains(needs.pre_ci.outputs.commit_message, '[acceptance test skip]')"
needs: pre_ci
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v4
- uses: gradle/actions/wrapper-validation@v3
pack-snapshot:
needs: [ validate-gradle-wrapper ]
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v4
- name: Set up JDK 11
Expand Down Expand Up @@ -89,7 +89,7 @@ jobs:
path: output-comparator/build/libs/output-comparator-*-cli.jar
pack-master:
needs: [ validate-gradle-wrapper ]
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v4
with:
Expand Down Expand Up @@ -117,7 +117,7 @@ jobs:
fetch-urls:
if: "!contains(needs.pre_ci.outputs.commit_message, '[acceptance test skip]')"
needs: pre_ci
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
steps:
- name: Checkout repository code
uses: actions/checkout@v4
Expand Down Expand Up @@ -174,7 +174,7 @@ jobs:
name: reports_${{ env.CONCATENATED_IDS }}
path: ${{ github.sha }}/output
merge-reports-artifacts:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
needs: [ get-reports ]
steps:
- name: Merge Artifacts
Expand All @@ -185,7 +185,7 @@ jobs:
delete-merged: true
compare-outputs:
needs: [ merge-reports-artifacts ]
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v4
- name: Download comparator .jar file from previous job
Expand Down
18 changes: 16 additions & 2 deletions .github/workflows/end_to_end.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ on:
- 'acceptance_test.yml'
- 'web/**'
- '.github/workflows/**'
workflow_dispatch:
jobs:
validate_gradle_wrapper:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -104,8 +105,21 @@ jobs:
bash ./scripts/queue_runner.sh --exclude-master $queue
env:
OUTPUT_BASE: ${{ github.sha }}
- name: Extract ID from JSON
id: extract-id
run: echo "feed_id=$(echo '${{ matrix.data }}' | jq -r '.id')" >> $GITHUB_ENV
- name: Persist reports
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: reports_snapshot
name: reports_snapshot_${{ env.feed_id }}
path: ${{ github.sha }}/output
merge-reports-artifacts:
runs-on: ubuntu-latest
needs: [ run-on-data ]
steps:
- name: Merge Artifacts
uses: actions/upload-artifact/merge@v4
with:
name: reports_snapshot
pattern: reports_snapshot_*
delete-merged: true

0 comments on commit e1e34ea

Please sign in to comment.