Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update generic error message #196

Merged
merged 2 commits into from
Dec 2, 2024
Merged

feat: update generic error message #196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79d80b5
update error message
Alessandro100 Dec 2, 2024
babe167
update error message
Alessandro100 Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions website/src/components/Result.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,21 +25,20 @@ const errorsCountFormated = computed(() => {
<div v-if="result.summary">
<h3 class="mt-4 mb-4">Result</h3>

<b-alert
v-if="result.summary.versionUnimplemented"
variant="danger"
show
>
Sorry, this version is not yet implemented or not detectable !
<b-alert v-if="result.summary.versionUnimplemented" variant="danger" show>
Sorry, the validator failed to parse this file. Please check that the URL is available and points to a
<a href="https://github.com/MobilityData/gbfs/blob/master/gbfs.md#gbfsjson" target='_blank'
rel='noreferrer'>gbfs.json</a> file. If you have any questions, please write to <a
href='mailto:[email protected]' target='_blank' rel='noreferrer'>
[email protected]
</a>. Thank you
</b-alert>
<div v-else>
<b-alert variant="info" show>
Detected version <b>{{ result.summary.version.detected }} </b> and
validate with
<a
:href="`https://github.com/MobilityData/gbfs/blob/v${result.summary.version.validated}/gbfs.md`"
><b>{{ result.summary.version.validated }}</b></a
>
<a :href="`https://github.com/MobilityData/gbfs/blob/v${result.summary.version.validated}/gbfs.md`"><b>{{
result.summary.version.validated }}</b></a>
</b-alert>

<div>
Expand Down
70 changes: 21 additions & 49 deletions website/src/pages/Visualization.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,37 +469,31 @@ provide('map', map)
<div>
<b-row>
<b-col>
<b-form-input
type="url"
v-model="url"
placeholder="https://exemple.com/gbfs.json"
></b-form-input>
<b-form-input type="url" v-model="url" placeholder="https://exemple.com/gbfs.json"></b-form-input>
</b-col>
<b-col class="flex-grow-0">
<b-button
@click="visualize"
variant="success"
style="white-space: nowrap"
:disabled="isLoading"
>Visualize !</b-button
>
<b-button @click="visualize" variant="success" style="white-space: nowrap" :disabled="isLoading">Visualize
!</b-button>
</b-col>
</b-row>
<b-row class="mt-3" v-if="summary.versionUnimplemented"
><b-col>
<b-row class="mt-3" v-if="summary.versionUnimplemented"><b-col>
<b-alert variant="danger" show class="mb-0">
Sorry, this version is not yet implemented or not detectable !
Sorry, the validator failed to parse this file. Please check that the URL is available and points to a
<a href="https://github.com/MobilityData/gbfs/blob/master/gbfs.md#gbfsjson" target='_blank'
rel='noreferrer'>gbfs.json</a> file. If you have any questions, please write to <a
href='mailto:[email protected]' target='_blank' rel='noreferrer'>
[email protected]
</a>. Thank you
</b-alert>
</b-col></b-row
>
</b-col></b-row>
<b-row class="mt-3">
<b-col cols="6">
<b-alert variant="primary" show>
<h4 class="alert-heading">
{{ stations ? stations.length : '-' }}
<small v-if="hasStationsDetails" class="text-muted">{{
vehiclesInStations
}}</small>
}}</small>
</h4>
<span>Stations</span>
</b-alert>
Expand All @@ -508,11 +502,7 @@ provide('map', map)
<b-alert variant="primary" show>
<h4 class="alert-heading">
{{ vehicles ? vehicles.length : '-' }}
<small
v-if="vehicleTypes && vehicleTypes.length > 1"
class="text-muted"
>{{ vehiclesCountByType }}</small
>
<small v-if="vehicleTypes && vehicleTypes.length > 1" class="text-muted">{{ vehiclesCountByType }}</small>
</h4>
<span>Dockless vehicles</span>
</b-alert>
Expand All @@ -526,25 +516,15 @@ provide('map', map)
<div class="map-overlay top left">
<div class="map-overlay-inner">
<ul class="list-unstyled mb-0">
<b-form-checkbox-group
id="checkbox-group-2"
v-model="selected"
name="flavour-2"
>
<b-form-checkbox-group id="checkbox-group-2" v-model="selected" name="flavour-2">
<li>
<b-form-checkbox name="selected-stations" value="stations"
>&nbsp;Stations</b-form-checkbox
>
<b-form-checkbox name="selected-stations" value="stations">&nbsp;Stations</b-form-checkbox>
</li>
<li>
<b-form-checkbox name="selected-stations" value="vehicles"
>&nbsp;Dockless</b-form-checkbox
>
<b-form-checkbox name="selected-stations" value="vehicles">&nbsp;Dockless</b-form-checkbox>
</li>
<li>
<b-form-checkbox name="selected-stations" value="geofencing"
>&nbsp;Geofencing</b-form-checkbox
>
<b-form-checkbox name="selected-stations" value="geofencing">&nbsp;Geofencing</b-form-checkbox>
</li>
</b-form-checkbox-group>
</ul>
Expand All @@ -555,21 +535,12 @@ provide('map', map)
<div class="map-overlay-inner" v-if="vehicles">
<h5>Dockless vehicles</h5>
<ul class="list-unstyled mb-0">
<li
v-for="vtff in vehicleTypesFormFactor"
:key="vtff"
class="d-flex align-items-center"
>
<span
class="vehicle-type d-inline-block"
:class="`vehicle-type-${vtff.toLowerCase()}`"
></span>
<li v-for="vtff in vehicleTypesFormFactor" :key="vtff" class="d-flex align-items-center">
<span class="vehicle-type d-inline-block" :class="`vehicle-type-${vtff.toLowerCase()}`"></span>
{{ vtff }}
</li>
<li v-if="!vehicleTypesFormFactor">
<span
class="vehicle-type d-inline-block vehicle-type-unknown"
></span>
<span class="vehicle-type d-inline-block vehicle-type-unknown"></span>
unknown
</li>
</ul>
Expand Down Expand Up @@ -628,6 +599,7 @@ provide('map', map)
&.left {
left: 0;
}

&.top {
top: 0;
}
Expand Down