feat: update generic error message #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for gbfs-validator ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
richfab
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
LGTM! You can merge.
Thank you for working on this @Alessandro100 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #194
Changed error message from
Old: "Sorry, this version is not yet implemented or not detectable !"
New: "Sorry, the validator failed to parse this file. Please check that the URL is available and points to a gbfs.json file. If you have any questions, please write to [email protected]. Thank you
Also ran Vue linter - no functionality changed
How to test
On the validator input a non valid gbfs link ex:
https://www.mibicitubici.gob.ar/you should see the error message