Feat/rust cicd #131
Feat/rust cicd #131
Conversation
|
Thank you for opening/editing this pull request. Please update the models/java/gbfs-java-model/pom.xml version so that your changes will be published. |
|
Thank you for opening/editing this pull request. Please update the models/rust/Cargo.toml version so that your changes will be published. |
| env: | ||
| CARGO_REGISTRY_TOKEN: "op://rbiv7rvkkrsdlpcrz3bmv7nmcu/ms6rxv2lhpok44mg32wuihbv7q/credential" |
There was a problem hiding this comment.
We need to add the 1password token to be able to connect with the proper vault:
| env: | |
| CARGO_REGISTRY_TOKEN: "op://rbiv7rvkkrsdlpcrz3bmv7nmcu/ms6rxv2lhpok44mg32wuihbv7q/credential" | |
| env: | |
| OP_SERVICE_ACCOUNT_TOKEN: ${{ secrets.OP_SERVICE_ACCOUNT_TOKEN }} | |
| CARGO_REGISTRY_TOKEN: "op://rbiv7rvkkrsdlpcrz3bmv7nmcu/ms6rxv2lhpok44mg32wuihbv7q/credential" |
There was a problem hiding this comment.
good catch! OP_SERVICE_ACCOUNT_TOKEN should already be a secret in this repo
| - name: Publish to crates.io | ||
| env: | ||
| CARGO_REGISTRY_TOKEN: ${{ env.CARGO_REGISTRY_TOKEN }} | ||
| run: cargo publish --token $CARGO_REGISTRY_TOKEN |
There was a problem hiding this comment.
Sorry for my lack of knowledge of Rust. Does cargo publish test and build also? If not, I suggest building and testing before publishing.
There was a problem hiding this comment.
The tests and build are run in the PR check .github/workflows/rust_pr_check.yml, and yes cargo publish builds and publishes
There was a problem hiding this comment.
I just looked up cargo publish also runs tests
Add the ability to publish Rust crate for
gbfs_typesas well as PR checks. Modified the readme.Will fail the publish build if the version in Cargo.toml is not changed