Skip to content
This repository has been archived by the owner on May 21, 2024. It is now read-only.

Remove Best Practices content merged into spec (Phase 2) #60

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

Sergiodero
Copy link
Contributor

Referenced from Issue #396 in the google/transit repo.

A recently implemented proposal has merged specific best practices directly into the GTFS specification. This merge included content from the Dataset Publishing & General Practice guidelines and the Practice Recommendations for all files sections from the Best Practices document.

This proposal removes the duplicated content from the Best Practices document, to avoid duplicity and consolidating a single source of truth.

- Updated "Document Structure" section
- Removed "Dataset Publishing & General Practices" section
- Removed "All Files" subsection within "Practice Recommendations Organized by File" section
@Sergiodero Sergiodero requested a review from emmambd November 17, 2023 15:20
@Sergiodero Sergiodero changed the title Removed content merged into spec Remove Best Practices content merged into spec (Phase 2) Nov 17, 2023
Copy link
Contributor

@isabelle-dr isabelle-dr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for working on this @Sergiodero!

Copy link
Contributor

@emmambd emmambd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, LGTM.

@Sergiodero
Copy link
Contributor Author

I'm calling a vote as per the process outlined in the GTFS Schedule Best Practices Amendment Process.

This vote is for the removal of best practices already merged into the spec google/transit#406.

Voting ends on 2023-12-26 at 23:59:59 UTC.

Thanks!

@bdferris-v2
Copy link

+1 from Google

@Sergiodero
Copy link
Contributor Author

@doconnoronca
Copy link

+1 TransSee

@leonardehrenfried
Copy link

leonardehrenfried commented Dec 20, 2023

+1 OTP

@drewda
Copy link

drewda commented Dec 20, 2023

+1 from @interline-io

(and thank you to @Sergiodero for the "housekeeping")

@evansiroky
Copy link

+1 Caltrans

@jfabi
Copy link

jfabi commented Dec 26, 2023

+1 from the @mbta.

@Sergiodero
Copy link
Contributor Author

The vote ended on 2023-12-26 at 23:59:59 UTC. This PR passes with 6 votes in favor (from Google, TranSee, OTP, Interline Caltrans and MBTA) and 0 opposed!

Thanks to everyone who participated!

@Sergiodero Sergiodero merged commit 3a0abdb into master Jan 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants