Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slider range #35

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

Kiro-tagama
Copy link

Hi, I created a slider but I'm not sure about the performance
@carlos-garciamoran @sumansid

@sumansid
Copy link
Contributor

Can you add some screenshots or a video displaying how it works?

</GestureDetector>
</View>
</GestureHandlerRootView>
{/* Debugging info - remove or hide in production */}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the commented parts

@Kiro-tagama
Copy link
Author

betaSliderVideo.mp4

useSlider

in video is explicit the jump in animation, but i don't know what's the problem

i'm use

  • import debounce from 'lodash.debounce';
  • react-native-gesture-handler
  • react-native-reanimated

@sumansid thanks for help and review

@Kiro-tagama
Copy link
Author

and now scroll control breaks slider gesture

@sumansid
Copy link
Contributor

sumansid commented Sep 8, 2024

@Kiro-tagama in the video, the slider seems very slow. Can you confirm that? I cannot merge it if the performance is slow.

@Kiro-tagama
Copy link
Author

@Kiro-tagamano vídeo, o slider parece muito lento. Você pode confirmar isso? Não posso mesclá-lo se o desempenho for lento.

There is no performance problem, but there is a conflict in the scroll because there is vertical and horizontal interaction creating conflict in
I'm testing again on my emulator and physical device, and the video is from my emulator and because of the memory usage it creates this "slowness"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants