Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert scoring algorithm #2281

Closed
wants to merge 1 commit into from
Closed

Revert scoring algorithm #2281

wants to merge 1 commit into from

Conversation

devtty1er
Copy link

Fixes #1940

Checklist for PR

  • Run MobSF unit tests and lint tox -e lint,test
  • Tested Working on Linux, Mac, Windows, and Docker
  • Add unit test for any new Web API (Refer: StaticAnalyzer/tests.py)
  • Make sure tests are passing on your PR MobSF tests

@ajinabraham
Copy link
Member

ajinabraham commented Nov 14, 2023

We cannot revert the scoring logic. There are some outstanding issues that needs to be addressed.
#1940 (comment)

@ajinabraham
Copy link
Member

Closing this for now.

@devtty1er
Copy link
Author

"We cannot revert the scoring logic" is an oddly strong statement for something that is totally broken.

As @Prehistoic, @johnxguo and I have mentioned, more warnings can lead to higher (better) score.

To all MobSF users, I strongly recommend treating the score as useless, since it is.

@ajinabraham
Copy link
Member

As you know, the current scoring logic is not our first implementation. We had previous implementations which had issues and feedback from the community, thats why we had to update them. The current implementation is also not perfect, hence we have an open ticket to track it
#1940

Reverting to the old algorithm doesn’t give a holistic solution to the problem. If you have an alternative scoring proposal PR we are happy to review it and merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App Security Score inconsistencies
2 participants