allow selection to use a3 markers as imageUrls for point markers #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We could probably add a window/prompt when placing a marker which has a dropdown or an area with all of the a3 markers //Edit: just saw you already did something like this, we could integrate the color selection directly into the selection prompt. Need to look at your selection system to understand it a bit more |
- moves sequelize DB stuff and express routes to /lib commonJS modules - adds env use to docker-compose and node.js - node server will now connect to the DB, create the .env database if it doesn't exist, then populate it with the appropriate tables etc if not already set up - node server will also (wipe and) populate the markers found in /public/markers into the DB for api return to frontend - implements PostGIS (spatially-aware PostgresDB) in docker compose w persistent volume la3map_pg_data - docker compose file has been updated to support healthchecks for both services & app dependency on DB running - docker compose will send env variable IS_DOCKER if running via docker to adjust for service hostname rather than assuming the service is running on localhost, or whatever is provided as POSTGRES_HOST in .env - saves marker geo data as geometry columns instead of raw json
indig0fox
force-pushed
the
feature/a3-markers
branch
from
3281e05 to
dea4ff1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Markers have been brought in, and a placeholder will auto-open for marker selection when you load the page. This is a rough sketch and idea of choosing a marker by the addon its from, as some will have overlapping names.
Need some help integrating this somehow into the existing prompt set or a picker similar to 'color'. Once better put together, I can implement the marker recoloring to emulate in-game color variants.