Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🛠️FIX : Contact Us form Name validation #258

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

akash70629
Copy link
Contributor

📋 Description

The "Phone" field in the Contact Us form should only accept Numbers. Currently, the field allows users to input symbols and special characters, which may lead to invalid or spam submissions.

🔨 Changes Made

The "Phone" field in the Contact Us form only accepts Numbers. Fixes #257

✅ Checklist

Before submitting the PR, please make sure you have completed the following:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings.
  • I have tested it locally and it works fine.
  • Any dependent changes have been merged and published in downstream modules.

🏷️ Types of Changes

  • Bug fix (non-breaking change which fixes an issue) 🐛

🤝 Related Issues

None

Fixes #257

📸 Screenshots (if applicable)

Before

image

After

image

Copy link

vercel bot commented Oct 25, 2024

@akash70629 is attempting to deploy a commit to the mitulsonagara's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Oct 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
truth-tunnel ❌ Failed (Inspect) Oct 27, 2024 4:25pm

@MitulSonagara
Copy link
Owner

@MastanSayyad

Should i give labels to this PR?

Copy link
Collaborator

@MastanSayyad MastanSayyad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MitulSonagara
Copy link
Owner

@MastanSayyad

So should i close this PR or merge it as it is

@MastanSayyad
Copy link
Collaborator

you can merge it @MitulSonagara

@akash70629
Copy link
Contributor Author

@MastanSayyad

So should i close this PR or merge it as it is

close? why? 😕😕

@MitulSonagara
Copy link
Owner

@akash70629

coz there will be no labels and you have to solve the conflicts also

@akash70629 akash70629 reopened this Oct 26, 2024
@akash70629
Copy link
Contributor Author

@akash70629

coz there will be no labels and you have to solve the conflicts also

I fixed the conflict. Why there will be no labels !!!?

@MastanSayyad
Copy link
Collaborator

MastanSayyad commented Oct 26, 2024

@MitulSonagara you can merge this, he is not in top 100, also @akash70629 i recommend you to complete postman challenge to get 500 points on the leaderboard.

@MitulSonagara
Copy link
Owner

image

@MitulSonagara
Copy link
Owner

image

@akash70629
Copy link
Contributor Author

akash70629 commented Oct 27, 2024

image

Look, it's already there (errors), I just freshly clone the repo , and it's there ..... can you fix that first . then I'm fixing mine portion .

image

@MitulSonagara
Copy link
Owner

@akash70629

The main concern is not about the error the concern is about the project shoud work properly... The current version of project is working very well at deployment so i don't need to change anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛[BUG] : Contact Us form Phone validation
3 participants