Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Header UI Testing Implemented #221

Merged
merged 3 commits into from
Apr 11, 2024
Merged

Header UI Testing Implemented #221

merged 3 commits into from
Apr 11, 2024

Conversation

ojusharma
Copy link
Collaborator

  • Implemented Dynamic Header UI Testing depending on logged in user role

@ojusharma
Header UI Testing Implemented
824e056 
- Implemented Dynamic Header UI Testing depending on logged in user role
@ojusharma ojusharma added the enhancement New feature or request label Apr 11, 2024
@ojusharma ojusharma self-assigned this Apr 11, 2024
Sparshkhannaa
Sparshkhannaa approved these changes Apr 11, 2024
View reviewed changes
Copy link
Collaborator

@Sparshkhannaa Sparshkhannaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The testing is consistent and appropriate based on our project outline

@ojusharma
Fixed Commented Code Issue
54c2b1b 
- I had commented some tests during my implementation
- I have removed unused code and un-commented all other tests
@ojusharma ojusharma requested review from mahigangal and prathamkshah13 and removed request for MithishR and mahigangal April 11, 2024 08:03
prathamkshah13
prathamkshah13 approved these changes Apr 11, 2024
View reviewed changes
Copy link
Collaborator

@prathamkshah13 prathamkshah13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The testing is consistent and appropriate with the discussion in the Scrum meeting

@prathamkshah13 prathamkshah13 merged commit 11c8430 into main Apr 11, 2024
1 check passed
@prathamkshah13 prathamkshah13 deleted the ojus-testing-header branch April 11, 2024 08:18
@ojusharma ojusharma linked an issue Apr 11, 2024 that may be closed by this pull request
Implement Dynamic Header #196
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prathamkshah13 prathamkshah13 prathamkshah13 approved these changes

@Sparshkhannaa Sparshkhannaa Sparshkhannaa approved these changes

Assignees

@ojusharma ojusharma

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Dynamic Header
3 participants
@ojusharma @Sparshkhannaa @prathamkshah13