Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Output CSV and implement packet logger #226
base: dev
Are you sure you want to change the base?
Output CSV and implement packet logger #226
Changes from 3 commits
ee41264
e632532
f1b740d
2456b9a
d0a4d9e
668b032
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 15 in src/Core/RoveProtocol/Rovecomm.ts
GitHub Actions / test (windows-latest, lint)
Check warning on line 17 in src/Core/RoveProtocol/Rovecomm.ts
GitHub Actions / test (windows-latest, lint)
Check warning on line 19 in src/Core/RoveProtocol/Rovecomm.ts
GitHub Actions / test (windows-latest, lint)
Check warning on line 20 in src/Core/RoveProtocol/Rovecomm.ts
GitHub Actions / test (windows-latest, lint)
Check warning on line 49 in src/Core/RoveProtocol/Rovecomm.ts
GitHub Actions / test (windows-latest, lint)
Check warning on line 108 in src/Core/RoveProtocol/Rovecomm.ts
GitHub Actions / test (windows-latest, lint)
Check warning on line 339 in src/Core/RoveProtocol/Rovecomm.ts
GitHub Actions / test (windows-latest, lint)
Check warning on line 390 in src/Core/RoveProtocol/Rovecomm.ts
GitHub Actions / test (windows-latest, lint)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should specify that it's the received packet log, and include the timestamp so it doesn't overwrite if we save multiple logs before we analyze them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need to log that it was a success. We can assume it was successful if it didn't give an error. We should log this error to the app's logger, not the console log.
rovecomm.emit('all', 'Error saving log');
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should pass the exportPacket function as a parameter here instead of creating an anonymous function just to call it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manifest is unused, so can be removed. Commented line can be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unused css
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unused CSS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should add a clear button or only save up to like 100 packets for this since we don't want it to eat up the entire system's memory over the entire time of a task saving every packet that was sent.