Android testing Assignment #8
Conversation
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| - | Generic High Entropy Secret | b92d567 | local.properties | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
| @@ -0,0 +1,49 @@ | |||
| { | |||
There was a problem hiding this comment.
Kindly remove these and add to gitignore file. We should not commit the services file.
| @@ -0,0 +1,45 @@ | |||
| ## This file must *NOT* be checked into Version Control Systems, | |||
There was a problem hiding this comment.
Kindly remove these and add to gitignore file. We should not commit the local properties file.
| @@ -0,0 +1,30 @@ | |||
| { | |||
There was a problem hiding this comment.
Kindly remove these and add to gitignore file. We should not commit the services file.
There was a problem hiding this comment.
I am sorry, I forgot to delete those files, I have now deleted them and re initiated pull request
| @@ -0,0 +1,172 @@ | |||
| #!/usr/bin/env sh | |||
There was a problem hiding this comment.
What is the use of this file? Why do we need it? Should it be a gitignore?
| restore-keys: | | ||
| ${{ runner.os }}-gradle- | ||
|
|
||
| - name: Run AssessmentsSchoolHistoryDaoTest |
There was a problem hiding this comment.
This looks like a good hack, but does this mean every file to be tested would need to be added here? Lots of manual work and error prone approach? Shouldn't we automatically scan all files for tests and run them? There could be a better way to do this?
Done #6