-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add information about beach-head services #42
base: main
Are you sure you want to change the base?
Conversation
@mestadler can you please
|
Initial PR for the servicetemplate usage guide.
I re-organized some of the information already existing in this PR + more info into the following:
I think this is a good start for now for information on beach-head services. |
@jjainschigg-r Feel free to add Nick Chase as well, I couldn't find his github handle. |
### Verify 2A templates have been successfully reconciled | ||
|
||
For additional verification, check that the example templates packaged with 2A have | ||
been installed and are valid. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd describe the naming convention for templates we use: template-name-sem-ver-with-dashes
, replace concrete versions in provided outputs by X-Y-Z, like cluster-api-X-Y-Z
, add separate pages for predefined templates:
./pre-defined-provider-templates.md
./pre-defined-cluster-templates.md
./pre-defined-service-templates.md
(Description of bundled beach-head services #66)
where actual versions will be listed. And add references to them, like:
The output should be like the following:
NAME VALID cluster-api-X-Y-Z true cluster-api-provider-aws-X-Y-Z true cluster-api-provider-azure-X-Y-Z true cluster-api-provider-vsphere-X-Y-Z true hmc-X-Y-Z true k0smotron-X-Y-Z true projectsveltos-X-Y-Z trueThe actual list of pre-defined templates with versions could be found {link to corresponding file}
I believe it will simplify keeping documentation accurate in the future (for instance cluster template versions example is already outdated).
1. ManagedCluster `dev-cluster-1` would lose and its ingress-nginx (v4.11.3) would be deployed on its cluster. | ||
2. ManagedCluster `dev-cluster-2` would win and ingress-nginx (v4.11.0) would be deployed on its cluster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd reword it as:
MultiClusterService
"global-ingress" will take precedence overManagedCluster
"dev-cluster-1" and ingress-nginx (v4.11.3) defined inMultiClusterService
object will be deployed on the cluster.ManagedCluster
"dev-cluster-2" will take precedence overMultiClusterService
"global-ingress" and ingress-nginx (v4.11.0) defined inManagedCluster
object will be deployed on the cluster.
values: | | ||
victoriametrics: | ||
vmauth: | ||
ingress: | ||
host: vmauth.hmc0.example.net | ||
credentials: | ||
username: motel | ||
password: motel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does not related to documentation itself, but need to be fixed asap. Issue: Mirantis/hmc#817
Initial PR for the servicetemplate usage guide.