Fix k0s installation in airgap env #791
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a13x5
force-pushed
the
k0s-ag-bundle
branch
2 times, most recently
from
33c5133 to
2ed8abc
Compare
a13x5
commented
Dec 19, 2024
| CHARTS_PACKAGE_DIR ?= $(LOCALBIN)/charts | ||
| EXTENSION_CHARTS_PACKAGE_DIR ?= $(LOCALBIN)/charts/extensions | ||
| K0S_VERSION = $(shell $$YQ '.k0s.version' $(CLUSTER_TEMPLATES_DIR)/vsphere-standalone-cp/values.yaml) |
There was a problem hiding this comment.
This has to be evaluated recursively because of YQ var (which is exported later).
Unfortunately this will be executed on each reference (4 times), but tricks with eval look worse IMO
|
Separate k0s image is created and bundled. It's needed to serve k0s artifacts in the airgapped env via http. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #702
Still need to decide where to put k0s-image