Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate mgmt providers removal #574

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Conversation

zerospiel
Copy link
Member

  • forbid Management .spec.providers items removal if a ManagedCluster utilizes one of the removed providers
  • amends to CRDs descriptions

Closes #554

@zerospiel zerospiel force-pushed the mgmt_wh branch 5 times, most recently from 03072e8 to 7063957 Compare October 31, 2024 20:23
internal/webhook/management_webhook.go Outdated Show resolved Hide resolved
internal/webhook/management_webhook.go Outdated Show resolved Hide resolved
internal/webhook/management_webhook.go Outdated Show resolved Hide resolved
internal/webhook/management_webhook.go Outdated Show resolved Hide resolved
@zerospiel zerospiel force-pushed the mgmt_wh branch 2 times, most recently from 0668095 to d26b873 Compare November 1, 2024 15:56
@zerospiel zerospiel requested a review from Kshatrix November 1, 2024 15:56
@zerospiel zerospiel force-pushed the mgmt_wh branch 9 times, most recently from 8e48560 to 864e62a Compare November 8, 2024 13:47
* forbid Management .spec.providers items
  removal if a ManagedCluster utilizes one
  of the removed providers
* amends to CRDs descriptions

Closes Mirantis#554
@Kshatrix Kshatrix merged commit 23ace50 into Mirantis:main Nov 8, 2024
5 checks passed
@zerospiel zerospiel deleted the mgmt_wh branch November 8, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Forbid to remove the provider from Management if the provider is in use
2 participants