Fix - Initial version of hmc-templates release gets updated concurrently #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylewuolle
requested review from
Kshatrix,
eromanova and
a13x5
as code owners
…o it is passed in along with the helm values
kylewuolle
force-pushed
the
create-release-flag
branch
from
2110b96 to
98b4493
Compare
slysunkin
approved these changes
Oct 17, 2024
|
Rebase to pick up the e2e controller test, it might need to be fixed up for this, it may even be useful to add a test case to the controller test. |
Kshatrix
requested changes
Oct 18, 2024
| @@ -252,7 +252,7 @@ func (r *ReleaseReconciler) reconcileHMCTemplates(ctx context.Context, releaseNa | |||
| }, | |||
| } | |||
|
|
|||
| if releaseName == "" { | |||
| if releaseName == "" || r.CreateRelease { | |||
There was a problem hiding this comment.
we only need Release to be created as part of the hcm-templates chart during the initial hmc installation. We should probably rename it to avoid confusion (along with create-management, create-template-management) (although it's mentioned in the variable description)
|
Looks like this was fixed in another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple change to resolve #449.
Testing performed:
Updated hmc_values.yaml to set the createRelease flag to true
Executed
make hmc-chart-releaseRan
make kind-deploy registry-deploy dev-push dev-deploy dev-templates(make dev-apply without the dev-release target)Verified the release was created correctly
Updated hmc_values.yml to set the createRelease flag to false
Ran
make kind-deploy registry-deploy dev-push dev-deploy dev-templates(make dev-apply without the dev-release target)Verified the release was not created and there was no loop attempting to create it
ran
make dev-releaseand verified the release was installed correctlyAlso ran
make dev-applywith the createRelease flag set to false (clean version of hmc_values.yaml) and verified this works as well.